Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix: Use XML 1.1 on XML formatters (fixes #9607) (#9608)" #9667

Merged
merged 1 commit into from Nov 30, 2017

Conversation

platinumazure
Copy link
Member

This reverts commit 208fb0f.

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Revert a breaking change.

What changes did you make? (Give an overview)

Revert PR #9608.

This seems to be the wrong approach to fix #9607: Instead, ESLint errors should render the source text rather than the interpreted string (e.g., "\\b" instead of "\b"), to avoid the need for escaped entities.

Is there anything you'd like reviewers to focus on?

Not really.

@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly patch candidate This issue may necessitate a patch release in the next few days regression Something broke labels Nov 30, 2017
@not-an-aardvark
Copy link
Member

This seems to be the wrong approach to fix #9607: Instead, ESLint errors should render the source text rather than the interpreted string (e.g., "\b" instead of "\b"), to avoid the need for escaped entities.

This would still be a problem if the source text itself contains control characters, right?

@platinumazure
Copy link
Member Author

platinumazure commented Nov 30, 2017

This would still be a problem if the source text itself contains control characters, right?

Wait, is that seriously possible? I don't know nearly enough about what characters are allowed in JS files.

In any case, I still think we need to look for a different approach to resolving the original issue. Maybe the XML formatters need to string-replace control characters with placeholder text, to avoid outputting entities.

Do you object to reverting the commit, given at least 2-3 people reported the issue with XML 1.1 incompatibilities? Didn't see the approve, sorry.

@platinumazure platinumazure merged commit 1e362a0 into master Nov 30, 2017
@not-an-aardvark not-an-aardvark deleted the revert-xml-11 branch November 30, 2017 05:24
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 30, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly patch candidate This issue may necessitate a patch release in the next few days regression Something broke
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change XML output file's version to 1.1
2 participants