Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove currentFilename prop from Linter instances (refs #9161) #9219

Merged
merged 1 commit into from Sep 5, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This removes the undocumented currentFilename property from Linter instances.

This relies on #9218. The tests will pass after #9218 is merged.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark added the chore This change is not user-facing label Sep 3, 2017
@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gyandeeps, @nzakas and @mysticatea to be potential reviewers.

Copy link
Member

@ilyavolodin ilyavolodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a bit weary of those kind of changes. Even those those methods are not documented, their removal might be considered a breaking change, since it might break some existing tools.

@not-an-aardvark
Copy link
Member Author

¯\_(ツ)_/¯ I'm fine with it because we have the "use at your own risk" warning for undocumented APIs.

@platinumazure
Copy link
Member

Possible compromise: Could we consider this an Update rather than a Chore and make it semver-minor?

@eslintbot
Copy link

LGTM

@not-an-aardvark
Copy link
Member Author

I'm fine with including this in a semver-minor release as a compromise, although I don't see how it would end up there based on our semver policy. To me, it seems like one of the following is true:

  1. There are integration developers ignoring the "use at your own risk" warning, and we're willing to accomodate them to avoid breaking builds, so we consider it a breaking change, or:
  2. (1) isn't true, so this is just an internal refactor, which is semver-patch.

Basically, I don't see how this fits under Update: in either case.

@not-an-aardvark not-an-aardvark merged commit 2eedc1f into master Sep 5, 2017
@not-an-aardvark not-an-aardvark deleted the remove-current-filename branch September 5, 2017 16:23
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 5, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants