Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: avoid relying on undocumented Linter#getFilename API in tests #9218

Merged
merged 1 commit into from Sep 3, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This updates the tests for Linter to avoid relying on the undocumented getFilename method.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aladdin-add and @gyandeeps to be potential reviewers.

@not-an-aardvark not-an-aardvark added the chore This change is not user-facing label Sep 3, 2017
@eslintbot
Copy link

LGTM


linter.verify("foo;", {}, { filename: "foo.js" });
const result = linter.getFilename();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@not-an-aardvark Could we keep track of the functions like that, that we could possibly remove/make private in the next major release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in #9219

@not-an-aardvark not-an-aardvark merged commit ed6d088 into master Sep 3, 2017
@not-an-aardvark not-an-aardvark deleted the no-filename-linter-tests branch September 3, 2017 22:01
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 3, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants