Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix examples for prefer-numeric-literals #9155

Merged
merged 2 commits into from Oct 12, 2017
Merged

Docs: fix examples for prefer-numeric-literals #9155

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d2604c
wrong parseInt result
mobilutz Aug 25, 2017
f0d94d3
fix second documentation error
mobilutz Oct 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/rules/prefer-numeric-literals.md
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@ parseInt("767", 8) === 503;
parseInt("1F7", 16) === 255;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line also be corrected?

Number.parseInt("111110111", 2) === 503;
Number.parseInt("767", 8) === 503;
Number.parseInt("1F7", 16) === 255;
Number.parseInt("1F7", 16) === 503;
```

Examples of **correct** code for this rule:
Expand Down