Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix examples for prefer-numeric-literals #9155

Merged
merged 2 commits into from Oct 12, 2017
Merged

Docs: fix examples for prefer-numeric-literals #9155

merged 2 commits into from Oct 12, 2017

Conversation

mobilutz
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Number.parseInt("1F7", 16) -> 503

Is there anything you'd like reviewers to focus on?

Just check it in the console. 馃槈

Number.parseInt("1F7", 16) -> 503
@eslintbot
Copy link

Thanks for the pull request, @mobilutz! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@jsf-clabot
Copy link

jsf-clabot commented Aug 25, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! I think there's one other example in that file that should also be fixed.

@@ -21,7 +21,7 @@ parseInt("767", 8) === 503;
parseInt("1F7", 16) === 255;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line also be corrected?

@not-an-aardvark not-an-aardvark added the documentation Relates to ESLint's documentation label Aug 25, 2017
@kaicataldo
Copy link
Member

@mobilutz Friendly ping - anything we can do to help you land this?

@eslintbot
Copy link

Thanks for the pull request, @mobilutz! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@mobilutz
Copy link
Contributor Author

@not-an-aardvark @kaicataldo Sorry, the mail got lost in my inbox ;)
I fixed the second parseInt, it should be good to be merged now.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@platinumazure
Copy link
Member

Can you please sign our CLA? We can't merge anything unless the author signs the CLA. Thanks!

@mobilutz
Copy link
Contributor Author

Done

@kaicataldo
Copy link
Member

Thank you! Looks like a random CI failure - restarting.

@kaicataldo kaicataldo changed the title Documentaton for prefer-numeric-literals wrong Docs: fix examples for prefer-numeric-literals Oct 12, 2017
@kaicataldo kaicataldo merged commit 2d8a303 into eslint:master Oct 12, 2017
@kaicataldo
Copy link
Member

Thanks for contributing to ESLint!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 11, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants