New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: fix examples for prefer-numeric-literals #9155
Conversation
Number.parseInt("1F7", 16) -> 503
Thanks for the pull request, @mobilutz! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request! I think there's one other example in that file that should also be fixed.
@@ -21,7 +21,7 @@ parseInt("767", 8) === 503; | |||
parseInt("1F7", 16) === 255; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this line also be corrected?
@mobilutz Friendly ping - anything we can do to help you land this? |
Thanks for the pull request, @mobilutz! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
@not-an-aardvark @kaicataldo Sorry, the mail got lost in my inbox ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing!
Can you please sign our CLA? We can't merge anything unless the author signs the CLA. Thanks! |
Done |
Thank you! Looks like a random CI failure - restarting. |
Thanks for contributing to ESLint! |
What is the purpose of this pull request? (put an "X" next to item)
[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Number.parseInt("1F7", 16)
->503
Is there anything you'd like reviewers to focus on?
Just check it in the console. 馃槈