New: Add eslintIgnore support to package.json (fixes #8458) #8690

VictorHom · 2017-06-06T01:54:44Z

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[] Add something to the core
[X] Other, please explain: Add option to add ignore paths/fles to package.json with an eslintIgnore attribute

See #8458.

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

eslintbot · 2017-06-06T01:54:45Z

LGTM

mention-bot · 2017-06-06T01:54:47Z

@VictorHom, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gronke, @IanVS and @not-an-aardvark to be potential reviewers.

eslintbot · 2017-06-06T16:55:55Z

LGTM

eslintbot · 2017-06-07T02:28:33Z

LGTM

eslintbot · 2017-06-07T02:32:32Z

LGTM

VictorHom · 2017-06-07T02:34:18Z

@not-an-aardvark when you have availability, can you review this pr?

eslintbot · 2017-06-07T02:43:33Z

LGTM

not-an-aardvark

This generally looks like the right idea, but I think there was some confusion because the eslintIgnore property should be a separate key in package.json, not something that goes in the eslintConfig object. That might make the implementation a bit simpler.

not-an-aardvark · 2017-06-07T06:27:54Z

lib/ignored-paths.js

+                    const packageJSONPath = findPackageJSONFile(options.cwd);
+
+                    if (packageJSONPath) {
+                        const configOptions = config.load(packageJSONPath, configContext);


I don't think it's necessary to load the file as a config. You can just call read/parse the file as JSON to check whether it has an eslintIgnore key.

not-an-aardvark · 2017-06-07T06:29:17Z

conf/config-schema.json

@@ -9,7 +9,8 @@
        "settings": { "type": "object" },
        "extends": { "type": ["string", "array"] },
        "rules": { "type": "object" },
-        "parserOptions": { "type": "object" }
+        "parserOptions": { "type": "object" },
+        "eslintIgnore": { "type": ["array"] }


I think the eslintIgnore option shouldn't be part of the config -- it should be outside of the eslintConfig object. So a package.json file might look like this:

{ "eslintConfig": { "rules": { "semi": "error" } }, "eslintIgnore": [ "*.test.js" ] }

eslintbot · 2017-06-07T18:06:29Z

LGTM

eslintbot · 2017-06-07T18:26:17Z

LGTM

eslintbot · 2017-06-07T18:35:28Z

LGTM

not-an-aardvark

Thanks! This generally looks good, I just have a few small nitpicks.

not-an-aardvark · 2017-06-11T20:51:33Z

lib/ignored-paths.js

 //------------------------------------------------------------------------------
 // Constants
 //------------------------------------------------------------------------------

 const ESLINT_IGNORE_FILENAME = ".eslintignore";
+const ESLINT_PACKAGE_JSON = "package.json";


Nitpick: Can you rename this constant to something like PACKAGE_JSON_FILENAME? The filename package.json isn't eslint-specific.

(Actually, it might not be necessary to use a constant for this at all, since it's a Node convention that probably isn't going to change.)

not-an-aardvark · 2017-06-11T20:53:55Z

lib/ignored-paths.js

+                        const packageJSONOptions = JSON.parse(fs.readFileSync(packageJSONPath, "utf8"));
+
+                        if (packageJSONOptions.eslintIgnore) {
+                            packageJSONOptions.eslintIgnore.forEach(pattern => {


Can you add an assertion that packageJSONOptions.eslintIgnore is an array, rather than just checking that it exists? If someone accidentally has a file like this, then eslint will currently throw a confusing error.

{ "eslintIgnore": "foo.js" }

not-an-aardvark · 2017-06-11T21:02:38Z

tests/lib/ignored-paths.js

+            assert.isTrue(ignoredPaths.contains("world.js"));
+        });
+
+        it("should not load package.json's eslintIgnore files if specified ignore file", () => {


Nitpick: the names of these tests were a bit confusing to me at first. Would you mind rewording them?

I wasn't sure what "load" means in this context (since eslint as a whole would explicitly not load the files that were ignored). It might be better to say "should use package.json's eslintIgnore files".

Can you say ".eslintignore file" rather than "ignore file"? I wasn't sure whether "ignore file" referred to a file being ignored or the .eslintignore file itself.

not-an-aardvark · 2017-06-11T21:03:24Z

tests/lib/ignored-paths.js

+            const ignoredPaths = new IgnoredPaths({ ignore: true, cwd: getFixturePath() });
+
+            assert.isFalse(ignoredPaths.contains("hello.js"));
+            assert.isFalse(ignoredPaths.contains("world.js"));


Can you add an assertion that the .eslintignore file does get used in this case?

assert.isTrue(ignoredPaths.contains("sampleignorepattern"));

eslintbot · 2017-06-11T21:27:45Z

LGTM

VictorHom · 2017-06-11T21:47:59Z

addressed your comments and made updates

not-an-aardvark · 2017-06-11T21:52:58Z

Thanks, this looks good to me.

The one last thing to do would be to add documentation for this change so users know how to use it. Can you add a description of this change to this section somewhere?

eslintbot · 2017-06-11T22:23:59Z

LGTM

not-an-aardvark

Looks good to me. Thanks for contributing!

I'll just leave this open for another day or so in case anyone else wants to review it.

platinumazure

Left a few comments, but none of them are really showstoppers. Thanks for contributing!

platinumazure · 2017-06-11T22:49:47Z

docs/user-guide/configuring.md

@@ -775,6 +775,22 @@ You can also use your `.gitignore` file:

 Any file that follows the standard ignore file format can be used. Keep in mind that specifying `--ignore-path` means that any existing `.eslintignore` file will not be used. Note that globbing rules in `.eslintignore` follow those of `.gitignore`.

+### Using eslintIgnore in package.json
+
+If an .eslintIgnore file is not found and an alternate file is not specified, eslint will look in package.json for an eslintIgnore key to check for files to ignore.


Nitpick: The file is .eslintignore, all lowercase. Also, I think it would be good for both .eslintignore and eslintIgnore to have backticks around them to help call them out visually. Thanks!

platinumazure · 2017-06-11T22:52:42Z

lib/ignored-paths.js

+                        }
+                    }
+                } catch (e) {
+                    debug("Could not find package.json to check eslintIgnore property");


Wondering if we should have multiple try/catch and error logs, in order to distinguish between file not being found vs file was not valid JSON vs whatever other issues.

added the try-catch for possible invalid json in package.json

eslintbot · 2017-06-12T00:21:16Z

LGTM

eslintbot · 2017-06-12T00:24:21Z

LGTM

eslintbot · 2017-06-13T03:10:52Z

LGTM

VictorHom · 2017-06-13T13:43:44Z

not sure why licence/cla is stuck/ or what would make that pass

platinumazure · 2017-06-13T14:23:24Z

Closed/reopened to force license check. Sorry for the inconvenience. (Sometimes it just... doesn't happen, mysteriously. Then closing/reopening the PR will force it to rerun.)

kaicataldo

One comment - I also wonder if we should include some tests around error messaging.

kaicataldo · 2017-06-14T20:46:38Z

lib/ignored-paths.js

+                            debug("Could not read package.json file to check eslintIgnore property");
+                        }
+
+                        if (packageJSONOptions.eslintIgnore && Array.isArray(packageJSONOptions.eslintIgnore)) {


Should we throw an error if packageJSONOptions.eslintIgnore is not an array? Seems like it would silently not do anything in this case.

makes sense @kaicataldo

updated to throw an error when it isn't an array and added a test for that. I didn't write error tests for when the package.json isn't found or when package.json is in a bad format, as they don't relate to the behavior of the eslintIgnore property. They just throw, which will give a decent error message.

eslintbot · 2017-06-15T03:05:10Z

LGTM

eslintbot · 2017-06-15T03:15:44Z

LGTM

kaicataldo

One very minor nitpick, but otherwise this LGTM. Thanks for the amazing work you've been doing for ESLint!

kaicataldo · 2017-06-15T03:35:52Z

lib/ignored-paths.js

+                                    addPattern(this.ig.default, pattern);
+                                });
+                            } else {
+                                throw new Error("the package.json file eslintIgnore property requires an array of paths");


Nitpick: The other error messages begin with a capital letter - maybe this one should also, for consistency's sake?

eslintbot · 2017-06-15T10:29:26Z

LGTM

kaicataldo

LGTM. Thanks for contributing to ESLint!

deckar01 · 2017-06-15T15:54:02Z

Thanks for coding and reviewing this! Can't wait to try it out.

1817: Update eslint to the latest version 🚀 r=jniles ## Version **4.1.0** of [eslint](https://github.com/eslint/eslint) just got published. <table> <tr> <th align=left> Dependency </td> <td> eslint </td> </tr> <tr> <th align=left> Current Version </td> <td> 3.19.0 </td> </tr> <tr> <th align=left> Type </td> <td> devDependency </td> </tr> </table> The version **4.1.0** is **not covered** by your **current version range**. Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though. I recommend you look into these changes and try to get onto the latest version of eslint. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update. --- <details> <summary>Release Notes</summary> <strong>v4.1.0</strong> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e8f1362ab640c883a5d296e951308fab22073e7f" class="commit-link"><tt>e8f1362</tt></a> Docs: Remove wrong descriptions in <code>padded-block</code> rule (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8783" class="issue-link js-issue-link" data-url="eslint/eslint#8783" data-id="237771100" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8783</a>) (Plusb Preco)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/291a78302c1d5d402c6582b3f4cc836e61fde787" class="commit-link"><tt>291a783</tt></a> Update: <code>enforceForArrowConditionals</code> to <code>no-extra-parens</code> (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/6196" class="issue-link js-issue-link" data-url="eslint/eslint#6196" data-id="155067290" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#6196</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8439" class="issue-link js-issue-link" data-url="eslint/eslint#8439" data-id="220697521" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8439</a>) (Evilebot Tnawi)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a21dd32c46f95bc232a67929c224824692f94b70" class="commit-link"><tt>a21dd32</tt></a> New: Add <code>overrides</code>/<code>files</code> options for glob-based config (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/3611" class="issue-link js-issue-link" data-url="eslint/eslint#3611" data-id="104053558" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#3611</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8081" class="issue-link js-issue-link" data-url="eslint/eslint#8081" data-id="207675247" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8081</a>) (Sylvan Mably)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/879688ce96f80aa0692f732759c6f67a0c36c4c3" class="commit-link"><tt>879688c</tt></a> Update: Add ignoreComments option to no-trailing-spaces (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8061" class="issue-link js-issue-link" data-url="eslint/eslint#8061" data-id="206865549" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8061</a>) (Jake Roussel)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b58ae2e6d6bd4662b549ca5c0472943055a74df8" class="commit-link"><tt>b58ae2e</tt></a> Chore: Only instantiate fileEntryCache when cache flage set (perf) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8763" class="issue-link js-issue-link" data-url="eslint/eslint#8763" data-id="236756225" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8763</a>) (Gyandeep Singh)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/98512881f1fc2417011247931fa089d987ee8cc6" class="commit-link"><tt>9851288</tt></a> Update: fix indent errors on multiline destructure (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8729" class="issue-link js-issue-link" data-url="eslint/eslint#8729" data-id="235733166" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8729</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8756" class="issue-link js-issue-link" data-url="eslint/eslint#8756" data-id="236673913" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8756</a>) (Victor Hom)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3608f06c2a412587c2d05dec0297803b25f3e630" class="commit-link"><tt>3608f06</tt></a> Docs: Increase visibility of code of conduct (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8758" class="issue-link js-issue-link" data-url="eslint/eslint#8758" data-id="236687424" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8758</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8764" class="issue-link js-issue-link" data-url="eslint/eslint#8764" data-id="236758243" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8764</a>) (Kai Cataldo)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/673a58bc8420075ba698cee6762e17322a5263c3" class="commit-link"><tt>673a58b</tt></a> Update: support multiple fixes in a report (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/7348" class="issue-link js-issue-link" data-url="eslint/eslint#7348" data-id="182620143" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#7348</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8101" class="issue-link js-issue-link" data-url="eslint/eslint#8101" data-id="208681921" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8101</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/7a1bc3893ab55d0ab16ccf4b7a62c85329ab4007" class="commit-link"><tt>7a1bc38</tt></a> Fix: don't pass default parserOptions to custom parsers (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8744" class="issue-link js-issue-link" data-url="eslint/eslint#8744" data-id="236336414" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8744</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8745" class="issue-link js-issue-link" data-url="eslint/eslint#8745" data-id="236373829" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8745</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c5b405280409698d14b62cbf3c87b7cf6cf71391" class="commit-link"><tt>c5b4052</tt></a> Chore: enable computed-property-spacing on ESLint codebase (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8760" class="issue-link js-issue-link" data-url="eslint/eslint#8760" data-id="236699991" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8760</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3419f6446e205d79d9db77f6c176b9167d1fd8a7" class="commit-link"><tt>3419f64</tt></a> Docs: describe how to use formatters on the formatter demo page (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8754" class="issue-link js-issue-link" data-url="eslint/eslint#8754" data-id="236645523" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8754</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a3ff8f21106cf8eca55978d4b3e053973f5e1bf2" class="commit-link"><tt>a3ff8f2</tt></a> Chore: combine tests in tests/lib/eslint.js and tests/lib/linter.js (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8746" class="issue-link js-issue-link" data-url="eslint/eslint#8746" data-id="236375849" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8746</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b7cc1e6fe995d52e581fcb2b1a44e37a18680e90" class="commit-link"><tt>b7cc1e6</tt></a> Fix: Space-infix-ops should ignore type annotations in TypeScript (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8341" class="issue-link js-issue-link" data-url="eslint/eslint#8341" data-id="217102387" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8341</a>) (Reyad Attiyat)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/46e73eea69abc2ba80bb1397c6779b8789dbd385" class="commit-link"><tt>46e73ee</tt></a> Fix: eslint --init installs wrong dependencies of popular styles (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/7338" class="issue-link js-issue-link" data-url="eslint/eslint#7338" data-id="182134634" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#7338</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8713" class="issue-link js-issue-link" data-url="eslint/eslint#8713" data-id="235217725" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8713</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a82361b65699653761436a2e9acc7f485c827ca0" class="commit-link"><tt>a82361b</tt></a> Chore: Prevent package-lock.json files from being created (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8742" class="issue-link js-issue-link" data-url="eslint/eslint#8742" data-id="236292937" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8742</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8747" class="issue-link js-issue-link" data-url="eslint/eslint#8747" data-id="236397701" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8747</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5f81a68a3904a559764872e3f0c7453865a6c6dc" class="commit-link"><tt>5f81a68</tt></a> New: Add eslintIgnore support to package.json (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8458" class="issue-link js-issue-link" data-url="eslint/eslint#8458" data-id="221689525" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8458</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8690" class="issue-link js-issue-link" data-url="eslint/eslint#8690" data-id="233757916" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8690</a>) (Victor Hom)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b5a70b4e8c20dc1ea3e31137706fc20da339f379" class="commit-link"><tt>b5a70b4</tt></a> Update: fix multiline binary operator/parentheses indentation (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8719" class="issue-link js-issue-link" data-url="eslint/eslint#8719" data-id="235421314" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8719</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ab8b0167bdaf3b8851eab3fbc2769f2bdd71677b" class="commit-link"><tt>ab8b016</tt></a> Update: fix MemberExpression indentation with "off" option (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8721" class="issue-link js-issue-link" data-url="eslint/eslint#8721" data-id="235434741" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8721</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8724" class="issue-link js-issue-link" data-url="eslint/eslint#8724" data-id="235459105" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8724</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/eb5d12c15a32084907f1c58bcbec721b5008495d" class="commit-link"><tt>eb5d12c</tt></a> Update: Add Fixer method to Linter API (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8631" class="issue-link js-issue-link" data-url="eslint/eslint#8631" data-id="230242473" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8631</a>) (Gyandeep Singh)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/26a2daab311c8c59942c52f436d380a195db2bd4" class="commit-link"><tt>26a2daa</tt></a> Chore: Cache fs reads in ignored-paths (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8363" class="issue-link js-issue-link" data-url="eslint/eslint#8363" data-id="218136776" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8363</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8706" class="issue-link js-issue-link" data-url="eslint/eslint#8706" data-id="235004396" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8706</a>) (Victor Hom)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 141 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/7d9e3beeb58c1ee71d53dfcfd3e3b0721dd79b46"><code>7d9e3be</code></a> <code>4.1.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e727b7bdfcfb0564aabd713b32364e6f4afcfeec"><code>e727b7b</code></a> <code>Build: changelog update for 4.1.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e8f1362ab640c883a5d296e951308fab22073e7f"><code>e8f1362</code></a> <code>Docs: Remove wrong descriptions in <code>padded-block</code> rule (#8783)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/291a78302c1d5d402c6582b3f4cc836e61fde787"><code>291a783</code></a> <code>Update: <code>enforceForArrowConditionals</code> to <code>no-extra-parens</code> (fixes #6196) (#8439)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a21dd32c46f95bc232a67929c224824692f94b70"><code>a21dd32</code></a> <code>New: Add <code>overrides</code>/<code>files</code> options for glob-based config (fixes #3611) (#8081)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/879688ce96f80aa0692f732759c6f67a0c36c4c3"><code>879688c</code></a> <code>Update: Add ignoreComments option to no-trailing-spaces (#8061)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b58ae2e6d6bd4662b549ca5c0472943055a74df8"><code>b58ae2e</code></a> <code>Chore: Only instantiate fileEntryCache when cache flage set (perf) (#8763)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/98512881f1fc2417011247931fa089d987ee8cc6"><code>9851288</code></a> <code>Update: fix indent errors on multiline destructure (fixes #8729) (#8756)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3608f06c2a412587c2d05dec0297803b25f3e630"><code>3608f06</code></a> <code>Docs: Increase visibility of code of conduct (fixes #8758) (#8764)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/673a58bc8420075ba698cee6762e17322a5263c3"><code>673a58b</code></a> <code>Update: support multiple fixes in a report (fixes #7348) (#8101)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/7a1bc3893ab55d0ab16ccf4b7a62c85329ab4007"><code>7a1bc38</code></a> <code>Fix: don't pass default parserOptions to custom parsers (fixes #8744) (#8745)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c5b405280409698d14b62cbf3c87b7cf6cf71391"><code>c5b4052</code></a> <code>Chore: enable computed-property-spacing on ESLint codebase (#8760)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3419f6446e205d79d9db77f6c176b9167d1fd8a7"><code>3419f64</code></a> <code>Docs: describe how to use formatters on the formatter demo page (#8754)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a3ff8f21106cf8eca55978d4b3e053973f5e1bf2"><code>a3ff8f2</code></a> <code>Chore: combine tests in tests/lib/eslint.js and tests/lib/linter.js (#8746)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b7cc1e6fe995d52e581fcb2b1a44e37a18680e90"><code>b7cc1e6</code></a> <code>Fix: Space-infix-ops should ignore type annotations in TypeScript (#8341)</code></li> </ul> <p>There are 141 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/eslint/eslint/compare/421aab44a9c167c82210bed52f68cf990b7edbea...7d9e3beeb58c1ee71d53dfcfd3e3b0721dd79b46">full diff</a></p> </details> <details> <summary>Not sure how things should work exactly?</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) Bot 🌴

VictorHom force-pushed the pr/specify_ignore_paths branch from e0a0368 to 8f8c788 Compare June 7, 2017 02:32

VictorHom changed the title ~~New: WIP add eslintIgnore support to package.json (fixes #8458)~~ New: Add eslintIgnore support to package.json (fixes #8458) Jun 7, 2017

kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion core Relates to ESLint's core APIs and features feature This change adds a new feature to ESLint labels Jun 7, 2017

not-an-aardvark suggested changes Jun 7, 2017

View reviewed changes

VictorHom force-pushed the pr/specify_ignore_paths branch from c8554c6 to ccf145f Compare June 7, 2017 18:26

VictorHom force-pushed the pr/specify_ignore_paths branch from ccf145f to 3993289 Compare June 7, 2017 18:35

not-an-aardvark self-requested a review June 8, 2017 01:43

VictorHom mentioned this pull request Jun 10, 2017

Chore: Cache fs reads in ignored-paths (fixes #8363) #8706

Merged

not-an-aardvark suggested changes Jun 11, 2017

View reviewed changes

not-an-aardvark approved these changes Jun 11, 2017

View reviewed changes

platinumazure reviewed Jun 11, 2017

View reviewed changes

VictorHom force-pushed the pr/specify_ignore_paths branch from 55bc9e8 to b79a04b Compare June 12, 2017 00:24

VictorHom force-pushed the pr/specify_ignore_paths branch from b79a04b to 6b4d535 Compare June 13, 2017 03:10

platinumazure closed this Jun 13, 2017

platinumazure reopened this Jun 13, 2017

kaicataldo suggested changes Jun 14, 2017

View reviewed changes

handle error when eslintIgnore is not array of paths

9ba9503

add eof newline

8a4da88

kaicataldo approved these changes Jun 15, 2017

View reviewed changes

clean up error message

810554d

kaicataldo approved these changes Jun 15, 2017

View reviewed changes

kaicataldo merged commit 5f81a68 into eslint:master Jun 15, 2017

VictorHom deleted the pr/specify_ignore_paths branch June 16, 2017 03:07

renovate bot mentioned this pull request Jun 24, 2017

Update dependency eslint to version 4.x homezen/hz-test-helpers#42

Merged

renovate-bot mentioned this pull request Jun 24, 2017

Renovate eslint packages singapore/lint-condo#308

Merged

This was referenced Jun 24, 2017

Update dependency eslint to version 4.1.0 renovatebot/renovate#341

Merged

Update dependency eslint to version 4.x xDae/styled-bootstrap#54

Closed

chore(deps): Update dependency eslint to version 4.x renovatebot/renovate#396

Merged

This was referenced Jul 7, 2017

Update dependency eslint to version 4.x algolia/react-element-to-jsx-string#94

Closed

chore(deps): update eslint to v4.x luftywiranda13/generator-bunny#161

Closed

chore(deps): update eslint to v4.x luftywiranda13/generator-bunny#162

Closed

Arcanemagus mentioned this pull request Aug 27, 2017

eslintIgnore property set in package.json is ignored AtomLinter/linter-eslint#991

Closed

eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018

eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018

New: Add eslintIgnore support to package.json (fixes #8458) #8690

New: Add eslintIgnore support to package.json (fixes #8458) #8690

Conversation

VictorHom commented Jun 6, 2017 • edited by platinumazure

eslintbot commented Jun 6, 2017

mention-bot commented Jun 6, 2017

eslintbot commented Jun 6, 2017

eslintbot commented Jun 7, 2017

eslintbot commented Jun 7, 2017

VictorHom commented Jun 7, 2017

eslintbot commented Jun 7, 2017

not-an-aardvark left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eslintbot commented Jun 7, 2017

eslintbot commented Jun 7, 2017

eslintbot commented Jun 7, 2017

not-an-aardvark left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eslintbot commented Jun 11, 2017

VictorHom commented Jun 11, 2017 • edited

not-an-aardvark commented Jun 11, 2017

eslintbot commented Jun 11, 2017

not-an-aardvark left a comment

Choose a reason for hiding this comment

platinumazure left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eslintbot commented Jun 12, 2017

eslintbot commented Jun 12, 2017

eslintbot commented Jun 13, 2017

VictorHom commented Jun 13, 2017

platinumazure commented Jun 13, 2017

kaicataldo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eslintbot commented Jun 15, 2017

eslintbot commented Jun 15, 2017

kaicataldo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eslintbot commented Jun 15, 2017

kaicataldo left a comment

Choose a reason for hiding this comment

deckar01 commented Jun 15, 2017 • edited

VictorHom commented Jun 6, 2017 •

edited by platinumazure

VictorHom commented Jun 11, 2017 •

edited

deckar01 commented Jun 15, 2017 •

edited