Update: `enforceForArrowConditionals` to `no-extra-parens` (fixes #6196) #8439

alexander-akait · 2017-04-10T16:21:20Z

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What rule do you want to change?

no-extra-parens

Does this change cause the rule to produce more or fewer warnings?

Fewer.

How will the change be implemented? (New option, new default behavior, etc.)?

Option.

Please provide some example code that this change will affect:

const d = c => (1 ? 2 : 3)

What does the rule currently do for this code?

Report error on extra parenthesis.

What will the rule do after it's changed?

Don't report on extra parent.

What changes did you make? (Give an overview)

Allow using parenthesis around conditional expression in arrow function. Now if you enable no-confusing-arrow and no-extra-parens you get error on this code:

const d = c => (1 ? 2 : 3)

At the moment, if your enable two rules this violates one of the principles:

No conflicts. No rule must directly conflict with another rule. For example, if we have a rule requiring semicolons, we cannot also have a rule disallowing semicolons (which is why we have one rule, semi, that does both).

Ref: #6196

Is there anything you'd like reviewers to focus on?

No

eslintbot · 2017-04-10T16:21:21Z

LGTM

mention-bot · 2017-04-10T16:21:22Z

@evilebottnawi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @not-an-aardvark, @vitorbal and @kaicataldo to be potential reviewers.

platinumazure · 2017-04-10T17:02:18Z

I wonder if we can bikeshed on the option name a bit (personally I can't tell without reading the source that confusingArrow: false will result in fewer warnings, though I see that other options in this rule behave the same way). Otherwise I'm 👍 to this enhancement.

not-an-aardvark · 2017-04-10T17:08:38Z

I agree about changing the name to something else that indicates what to do with confusing arrows, e.g. ignoreConfusingArrow.

Also, I realize that the name is taken from the no-confusing-arrow rule, but I feel like calling the pattern "confusing" is very vague. The rule, and this option, check for arrow functions with conditional expressions as the body. It's arguable whether that pattern is "confusing", and there are many other patterns with arrow functions that could also be considered "confusing" but aren't checked by this option. I think we should rename it to something more specific, e.g. ignoreArrowConditionals.

alexander-akait · 2017-04-10T17:23:31Z

@not-an-aardvark sound good name for me, what do others think?

platinumazure · 2017-04-10T17:31:02Z

👍 to ignoreArrowConditionals for me (though that would require inverting the boolean property).

@not-an-aardvark Unfortunately, in this rule, many other properties are false-valued to ignore them. Should we go for something like enforceForArrowConditionals here to get that consistency?

alexander-akait · 2017-04-11T06:45:55Z

@not-an-aardvark @platinumazure What is the final decision?

alexander-akait · 2017-04-19T13:12:13Z

ping

ilyavolodin · 2017-04-21T21:38:53Z

Looks like we dropped a ball on this PR. @not-an-aardvark @platinumazure can you settle on option name? I think I'm fine with enforceForArrowConditionals although it could be shorter:-)

not-an-aardvark · 2017-04-21T21:51:33Z

I'm fine with enforceForArrowConditionals.

platinumazure · 2017-04-21T21:53:58Z

As am I, let's use that name. Thanks!

eslintbot · 2017-04-22T12:37:21Z

LGTM

eslintbot · 2017-04-22T13:28:00Z

Thanks for the pull request, @evilebottnawi! I took a look to make sure it's ready for merging and found some changes are needed:

The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

eslintbot · 2017-04-22T13:29:29Z

Thanks for the pull request, @evilebottnawi! I took a look to make sure it's ready for merging and found some changes are needed:

The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

eslintbot · 2017-04-22T13:30:55Z

Thanks for the pull request, @evilebottnawi! I took a look to make sure it's ready for merging and found some changes are needed:

The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

alexander-akait · 2017-04-22T13:35:55Z

/cc @not-an-aardvark @ilyavolodin @platinumazure
Sorry, but rule about 72 characters is very uncomfortable. Bot do not give me lgtm, because of the long name of the option, 😭

As mentioned in slevithan#108 (comment) This was done with the help of [lebab], using `lebeb --replace src --transform arrow`. [lebab]: https://github.com/lebab/lebab I did have to add an `/* eslint disable no-confusing-arrow */` comment to suppress an error. Once eslint/eslint#8439 is merged and released, we can upgrade eslint and remove the comment.

As mentioned in #108 (comment) This was done with the help of [lebab], using `lebeb --replace src --transform arrow`. [lebab]: https://github.com/lebab/lebab I did have to add an `/* eslint disable no-confusing-arrow */` comment to suppress an error. Once eslint/eslint#8439 is merged and released, we can upgrade eslint and remove the comment.

alexander-akait · 2017-05-07T20:31:14Z

/cc @not-an-aardvark, @vitorbal and @kaicataldo friendly ping

not-an-aardvark · 2017-05-07T20:42:39Z

docs/rules/no-extra-parens.md

@@ -22,6 +22,7 @@ This rule has an object option for exceptions to the `"all"` option:
 * `"returnAssign": false` allows extra parentheses around assignments in `return` statements
 * `"nestedBinaryExpressions": false` allows extra parentheses in nested binary expressions
 * `"ignoreJSX": "none|all|multi-line|single-line"` allows extra parentheses around no/all/multi-line/single-line JSX components. Defaults to `none`.
+* `"enforceForArrowConditionals": false` allows extra parentheses around arrow conditionals expression


Can you be more descriptive here? For example, "allows extra parentheses around ternary expressions which are the body of an arrow function"

not-an-aardvark · 2017-05-07T20:45:18Z

lib/rules/no-extra-parens.js

@@ -431,6 +435,10 @@ module.exports = {
                    return;
                }

+                if (node.body.type === "ConditionalExpression" && ENFORCE_FOR_ARROW_CONDITIONALS) {
+                    return;
+                }


I think the option is backwards. When enforceForArrowConditionals is true, the conditional expressions should be checked. When enforceForArrowConditionals is false, conditional expressions should not be checked.

No, if enforceForArrowConditionals is true, then I would expect the rule to enforce that there are no extra parentheses, so it should report that case. If enforceForArrowConditionals is false, then the rule should not report the extra parens.

So the following examples are valid:

/* eslint no-extra-parens: [error, { enforceForArrowConditionals: true }] */ var a = (b) => 1 ? 2 : 3;

/* eslint no-extra-parens: [error, { enforceForArrowConditionals: false }] */ var a = (b) => 1 ? 2 : 3;

/* eslint no-extra-parens: [error, { enforceForArrowConditionals: false }] */ var a = (b) => (1 ? 2 : 3);

The following example is invalid:

/* eslint no-extra-parens: [error, { enforceForArrowConditionals: true }] */ var a = (b) => (1 ? 2 : 3);

@not-an-aardvark Thanks for answer! I understood this, so I deleted my comment :sorry:

not-an-aardvark · 2017-05-07T20:46:01Z

tests/lib/rules/no-extra-parens.js

+                }
+            ],
+            output: "var a = (b) => 1 ? 2 : 3"
+        },


Can you add a test for () => ((1 ? 2 : 3))? I think an error should be reported because there is no reason to use multiple sets of parentheses there.

@not-an-aardvark () => ((1 ? 2 : 3)) should be not error, right?

I think it should be an error, because there are multiple parentheses rather than just a single pair of parentheses.

eslintbot · 2017-05-09T17:24:10Z

LGTM

alexander-akait · 2017-05-09T17:33:50Z

Note: i reduced the description of the commit so that the bot validated it.

/cc @not-an-aardvark, @vitorbal and @kaicataldo friendly ping

…int#6196)

eslintbot · 2017-05-09T17:43:37Z

LGTM

alexander-akait · 2017-05-09T17:44:23Z

/cc @not-an-aardvark done 😄

not-an-aardvark

Looks good to me. Thanks!

jpickwell · 2017-06-07T01:02:05Z

Can this get merged? Reading through the comments, it sounds like you've reached a merging point. I don't like having to use an eslint-disable-line comment to stop no-extra-parens from complaining. I also can't use an explicit return statement because of arrow-body-style.

kaicataldo · 2017-06-07T04:29:29Z

I'll champion this. @eslint/eslint-team Would anyone else like to support this change? We only need one more 👍.

kaicataldo

LGTM. Sorry for the delay on reviewing this!

kaicataldo · 2017-06-21T22:51:53Z

@eslint/eslint-team Would anyone else like to support this change? We only need one more 👍.

qfox · 2017-06-21T23:30:05Z

Nice feature. Here is my 👍

ilyavolodin · 2017-06-22T01:07:26Z

This issue is now accepted.

kaicataldo · 2017-06-22T15:43:00Z

LGTM. Thanks for contributing to ESLint!

1817: Update eslint to the latest version 🚀 r=jniles ## Version **4.1.0** of [eslint](https://github.com/eslint/eslint) just got published. <table> <tr> <th align=left> Dependency </td> <td> eslint </td> </tr> <tr> <th align=left> Current Version </td> <td> 3.19.0 </td> </tr> <tr> <th align=left> Type </td> <td> devDependency </td> </tr> </table> The version **4.1.0** is **not covered** by your **current version range**. Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though. I recommend you look into these changes and try to get onto the latest version of eslint. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update. --- <details> <summary>Release Notes</summary> <strong>v4.1.0</strong> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e8f1362ab640c883a5d296e951308fab22073e7f" class="commit-link"><tt>e8f1362</tt></a> Docs: Remove wrong descriptions in <code>padded-block</code> rule (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8783" class="issue-link js-issue-link" data-url="eslint/eslint#8783" data-id="237771100" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8783</a>) (Plusb Preco)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/291a78302c1d5d402c6582b3f4cc836e61fde787" class="commit-link"><tt>291a783</tt></a> Update: <code>enforceForArrowConditionals</code> to <code>no-extra-parens</code> (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/6196" class="issue-link js-issue-link" data-url="eslint/eslint#6196" data-id="155067290" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#6196</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8439" class="issue-link js-issue-link" data-url="eslint/eslint#8439" data-id="220697521" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8439</a>) (Evilebot Tnawi)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a21dd32c46f95bc232a67929c224824692f94b70" class="commit-link"><tt>a21dd32</tt></a> New: Add <code>overrides</code>/<code>files</code> options for glob-based config (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/3611" class="issue-link js-issue-link" data-url="eslint/eslint#3611" data-id="104053558" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#3611</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8081" class="issue-link js-issue-link" data-url="eslint/eslint#8081" data-id="207675247" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8081</a>) (Sylvan Mably)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/879688ce96f80aa0692f732759c6f67a0c36c4c3" class="commit-link"><tt>879688c</tt></a> Update: Add ignoreComments option to no-trailing-spaces (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8061" class="issue-link js-issue-link" data-url="eslint/eslint#8061" data-id="206865549" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8061</a>) (Jake Roussel)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b58ae2e6d6bd4662b549ca5c0472943055a74df8" class="commit-link"><tt>b58ae2e</tt></a> Chore: Only instantiate fileEntryCache when cache flage set (perf) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8763" class="issue-link js-issue-link" data-url="eslint/eslint#8763" data-id="236756225" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8763</a>) (Gyandeep Singh)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/98512881f1fc2417011247931fa089d987ee8cc6" class="commit-link"><tt>9851288</tt></a> Update: fix indent errors on multiline destructure (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8729" class="issue-link js-issue-link" data-url="eslint/eslint#8729" data-id="235733166" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8729</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8756" class="issue-link js-issue-link" data-url="eslint/eslint#8756" data-id="236673913" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8756</a>) (Victor Hom)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3608f06c2a412587c2d05dec0297803b25f3e630" class="commit-link"><tt>3608f06</tt></a> Docs: Increase visibility of code of conduct (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8758" class="issue-link js-issue-link" data-url="eslint/eslint#8758" data-id="236687424" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8758</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8764" class="issue-link js-issue-link" data-url="eslint/eslint#8764" data-id="236758243" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8764</a>) (Kai Cataldo)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/673a58bc8420075ba698cee6762e17322a5263c3" class="commit-link"><tt>673a58b</tt></a> Update: support multiple fixes in a report (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/7348" class="issue-link js-issue-link" data-url="eslint/eslint#7348" data-id="182620143" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#7348</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8101" class="issue-link js-issue-link" data-url="eslint/eslint#8101" data-id="208681921" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8101</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/7a1bc3893ab55d0ab16ccf4b7a62c85329ab4007" class="commit-link"><tt>7a1bc38</tt></a> Fix: don't pass default parserOptions to custom parsers (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8744" class="issue-link js-issue-link" data-url="eslint/eslint#8744" data-id="236336414" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8744</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8745" class="issue-link js-issue-link" data-url="eslint/eslint#8745" data-id="236373829" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8745</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c5b405280409698d14b62cbf3c87b7cf6cf71391" class="commit-link"><tt>c5b4052</tt></a> Chore: enable computed-property-spacing on ESLint codebase (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8760" class="issue-link js-issue-link" data-url="eslint/eslint#8760" data-id="236699991" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8760</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3419f6446e205d79d9db77f6c176b9167d1fd8a7" class="commit-link"><tt>3419f64</tt></a> Docs: describe how to use formatters on the formatter demo page (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8754" class="issue-link js-issue-link" data-url="eslint/eslint#8754" data-id="236645523" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8754</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a3ff8f21106cf8eca55978d4b3e053973f5e1bf2" class="commit-link"><tt>a3ff8f2</tt></a> Chore: combine tests in tests/lib/eslint.js and tests/lib/linter.js (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8746" class="issue-link js-issue-link" data-url="eslint/eslint#8746" data-id="236375849" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8746</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b7cc1e6fe995d52e581fcb2b1a44e37a18680e90" class="commit-link"><tt>b7cc1e6</tt></a> Fix: Space-infix-ops should ignore type annotations in TypeScript (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8341" class="issue-link js-issue-link" data-url="eslint/eslint#8341" data-id="217102387" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8341</a>) (Reyad Attiyat)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/46e73eea69abc2ba80bb1397c6779b8789dbd385" class="commit-link"><tt>46e73ee</tt></a> Fix: eslint --init installs wrong dependencies of popular styles (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/7338" class="issue-link js-issue-link" data-url="eslint/eslint#7338" data-id="182134634" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#7338</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8713" class="issue-link js-issue-link" data-url="eslint/eslint#8713" data-id="235217725" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8713</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a82361b65699653761436a2e9acc7f485c827ca0" class="commit-link"><tt>a82361b</tt></a> Chore: Prevent package-lock.json files from being created (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8742" class="issue-link js-issue-link" data-url="eslint/eslint#8742" data-id="236292937" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8742</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8747" class="issue-link js-issue-link" data-url="eslint/eslint#8747" data-id="236397701" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8747</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5f81a68a3904a559764872e3f0c7453865a6c6dc" class="commit-link"><tt>5f81a68</tt></a> New: Add eslintIgnore support to package.json (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8458" class="issue-link js-issue-link" data-url="eslint/eslint#8458" data-id="221689525" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8458</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8690" class="issue-link js-issue-link" data-url="eslint/eslint#8690" data-id="233757916" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8690</a>) (Victor Hom)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b5a70b4e8c20dc1ea3e31137706fc20da339f379" class="commit-link"><tt>b5a70b4</tt></a> Update: fix multiline binary operator/parentheses indentation (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8719" class="issue-link js-issue-link" data-url="eslint/eslint#8719" data-id="235421314" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8719</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ab8b0167bdaf3b8851eab3fbc2769f2bdd71677b" class="commit-link"><tt>ab8b016</tt></a> Update: fix MemberExpression indentation with "off" option (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8721" class="issue-link js-issue-link" data-url="eslint/eslint#8721" data-id="235434741" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8721</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8724" class="issue-link js-issue-link" data-url="eslint/eslint#8724" data-id="235459105" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8724</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/eb5d12c15a32084907f1c58bcbec721b5008495d" class="commit-link"><tt>eb5d12c</tt></a> Update: Add Fixer method to Linter API (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8631" class="issue-link js-issue-link" data-url="eslint/eslint#8631" data-id="230242473" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8631</a>) (Gyandeep Singh)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/26a2daab311c8c59942c52f436d380a195db2bd4" class="commit-link"><tt>26a2daa</tt></a> Chore: Cache fs reads in ignored-paths (fixes <a href="https://urls.greenkeeper.io/eslint/eslint/issues/8363" class="issue-link js-issue-link" data-url="eslint/eslint#8363" data-id="218136776" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8363</a>) (<a href="https://urls.greenkeeper.io/eslint/eslint/pull/8706" class="issue-link js-issue-link" data-url="eslint/eslint#8706" data-id="235004396" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#8706</a>) (Victor Hom)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 141 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/7d9e3beeb58c1ee71d53dfcfd3e3b0721dd79b46"><code>7d9e3be</code></a> <code>4.1.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e727b7bdfcfb0564aabd713b32364e6f4afcfeec"><code>e727b7b</code></a> <code>Build: changelog update for 4.1.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e8f1362ab640c883a5d296e951308fab22073e7f"><code>e8f1362</code></a> <code>Docs: Remove wrong descriptions in <code>padded-block</code> rule (#8783)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/291a78302c1d5d402c6582b3f4cc836e61fde787"><code>291a783</code></a> <code>Update: <code>enforceForArrowConditionals</code> to <code>no-extra-parens</code> (fixes #6196) (#8439)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a21dd32c46f95bc232a67929c224824692f94b70"><code>a21dd32</code></a> <code>New: Add <code>overrides</code>/<code>files</code> options for glob-based config (fixes #3611) (#8081)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/879688ce96f80aa0692f732759c6f67a0c36c4c3"><code>879688c</code></a> <code>Update: Add ignoreComments option to no-trailing-spaces (#8061)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b58ae2e6d6bd4662b549ca5c0472943055a74df8"><code>b58ae2e</code></a> <code>Chore: Only instantiate fileEntryCache when cache flage set (perf) (#8763)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/98512881f1fc2417011247931fa089d987ee8cc6"><code>9851288</code></a> <code>Update: fix indent errors on multiline destructure (fixes #8729) (#8756)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3608f06c2a412587c2d05dec0297803b25f3e630"><code>3608f06</code></a> <code>Docs: Increase visibility of code of conduct (fixes #8758) (#8764)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/673a58bc8420075ba698cee6762e17322a5263c3"><code>673a58b</code></a> <code>Update: support multiple fixes in a report (fixes #7348) (#8101)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/7a1bc3893ab55d0ab16ccf4b7a62c85329ab4007"><code>7a1bc38</code></a> <code>Fix: don't pass default parserOptions to custom parsers (fixes #8744) (#8745)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c5b405280409698d14b62cbf3c87b7cf6cf71391"><code>c5b4052</code></a> <code>Chore: enable computed-property-spacing on ESLint codebase (#8760)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3419f6446e205d79d9db77f6c176b9167d1fd8a7"><code>3419f64</code></a> <code>Docs: describe how to use formatters on the formatter demo page (#8754)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a3ff8f21106cf8eca55978d4b3e053973f5e1bf2"><code>a3ff8f2</code></a> <code>Chore: combine tests in tests/lib/eslint.js and tests/lib/linter.js (#8746)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/b7cc1e6fe995d52e581fcb2b1a44e37a18680e90"><code>b7cc1e6</code></a> <code>Fix: Space-infix-ops should ignore type annotations in TypeScript (#8341)</code></li> </ul> <p>There are 141 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/eslint/eslint/compare/421aab44a9c167c82210bed52f68cf990b7edbea...7d9e3beeb58c1ee71d53dfcfd3e3b0721dd79b46">full diff</a></p> </details> <details> <summary>Not sure how things should work exactly?</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) Bot 🌴

As mentioned in slevithan/xregexp#108 (comment) This was done with the help of [lebab], using `lebeb --replace src --transform arrow`. [lebab]: https://github.com/lebab/lebab I did have to add an `/* eslint disable no-confusing-arrow */` comment to suppress an error. Once eslint/eslint#8439 is merged and released, we can upgrade eslint and remove the comment.

platinumazure added enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules labels Apr 10, 2017

alexander-akait force-pushed the issue-6196 branch from 198ba8d to 4e3f367 Compare April 22, 2017 12:37

alexander-akait force-pushed the issue-6196 branch from 4e3f367 to 34e995c Compare April 22, 2017 13:27

alexander-akait force-pushed the issue-6196 branch from 34e995c to b0fb294 Compare April 22, 2017 13:29

alexander-akait force-pushed the issue-6196 branch from b0fb294 to 656293e Compare April 22, 2017 13:30

not-an-aardvark suggested changes May 7, 2017

View reviewed changes

alexander-akait force-pushed the issue-6196 branch from 656293e to 822793f Compare May 9, 2017 17:24

Update: enforceForArrowConditionals to no-extra-parens (fixes esl…

541c888

…int#6196)

alexander-akait force-pushed the issue-6196 branch from 822793f to 541c888 Compare May 9, 2017 17:43

not-an-aardvark approved these changes May 9, 2017

View reviewed changes

kaicataldo self-assigned this Jun 7, 2017

kaicataldo approved these changes Jun 7, 2017

View reviewed changes

not-an-aardvark changed the title ~~Update: add confusingArrow to no-extra-parens (fixes #6196)~~ Update: enforceForArrowConditionals to no-extra-parens (fixes #6196) Jun 7, 2017

ilyavolodin added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 22, 2017

kaicataldo merged commit 291a783 into eslint:master Jun 22, 2017

renovate bot mentioned this pull request Jun 24, 2017

Update dependency eslint to version 4.x homezen/hz-test-helpers#42

Merged

renovate-bot mentioned this pull request Jun 24, 2017

Renovate eslint packages singapore/lint-condo#308

Merged

This was referenced Jun 24, 2017

Update dependency eslint to version 4.1.0 renovatebot/renovate#341

Merged

Update dependency eslint to version 4.x xDae/styled-bootstrap#54

Closed

chore(deps): Update dependency eslint to version 4.x renovatebot/renovate#396

Merged

This was referenced Jul 7, 2017

Update dependency eslint to version 4.x algolia/react-element-to-jsx-string#94

Closed

chore(deps): update eslint to v4.x luftywiranda13/generator-bunny#161

Closed

chore(deps): update eslint to v4.x luftywiranda13/generator-bunny#162

Closed

eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018

eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018

Update: enforceForArrowConditionals to no-extra-parens (fixes #6196) #8439

Update: enforceForArrowConditionals to no-extra-parens (fixes #6196) #8439

Conversation

alexander-akait commented Apr 10, 2017 • edited

eslintbot commented Apr 10, 2017

mention-bot commented Apr 10, 2017

platinumazure commented Apr 10, 2017

not-an-aardvark commented Apr 10, 2017 • edited

alexander-akait commented Apr 10, 2017

platinumazure commented Apr 10, 2017 • edited

alexander-akait commented Apr 11, 2017

alexander-akait commented Apr 19, 2017

ilyavolodin commented Apr 21, 2017

not-an-aardvark commented Apr 21, 2017

platinumazure commented Apr 21, 2017

eslintbot commented Apr 22, 2017

eslintbot commented Apr 22, 2017

eslintbot commented Apr 22, 2017

eslintbot commented Apr 22, 2017

alexander-akait commented Apr 22, 2017 • edited

alexander-akait commented May 7, 2017

not-an-aardvark May 7, 2017

Choose a reason for hiding this comment

not-an-aardvark May 7, 2017

Choose a reason for hiding this comment

not-an-aardvark May 9, 2017

Choose a reason for hiding this comment

alexander-akait May 9, 2017

Choose a reason for hiding this comment

not-an-aardvark May 7, 2017

Choose a reason for hiding this comment

alexander-akait May 7, 2017

Choose a reason for hiding this comment

not-an-aardvark May 7, 2017

Choose a reason for hiding this comment

eslintbot commented May 9, 2017

alexander-akait commented May 9, 2017

eslintbot commented May 9, 2017

alexander-akait commented May 9, 2017

not-an-aardvark left a comment

Choose a reason for hiding this comment

jpickwell commented Jun 7, 2017

kaicataldo commented Jun 7, 2017

kaicataldo left a comment

Choose a reason for hiding this comment

kaicataldo commented Jun 21, 2017

qfox commented Jun 21, 2017

ilyavolodin commented Jun 22, 2017

kaicataldo commented Jun 22, 2017

Update: `enforceForArrowConditionals` to `no-extra-parens` (fixes #6196) #8439

Update: `enforceForArrowConditionals` to `no-extra-parens` (fixes #6196) #8439

alexander-akait commented Apr 10, 2017 •

edited

not-an-aardvark commented Apr 10, 2017 •

edited

platinumazure commented Apr 10, 2017 •

edited

alexander-akait commented Apr 22, 2017 •

edited