Fix: unicode-bom fixer insert BOM in appropriate location (fixes #8083) #8084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pantosha, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ehjay, @kaicataldo and @pedrottimark to be potential reviewers. |
|
|
|
LGTM |
mysticatea
added
accepted
mysticatea
suggested changes
Feb 15, 2017
There was a problem hiding this comment.
Thank you for contributing!
Implementation LGTM.
Could you add tests for this change?
The test file is here: https://github.com/eslint/eslint/blob/c7e64f30de7aa56e6e0c00ffd1f9ab398920b0b1/tests/lib/rules/unicode-bom.js
|
LGTM |
|
@mysticatea, please review again. I've added the test. |
gyandeeps
approved these changes
Feb 16, 2017
ilyavolodin
approved these changes
Feb 16, 2017
This was referenced Feb 20, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
See issue #8083
What changes did you make? (Give an overview)
Insert BOM at specific location using
fixer.insertTextBeforeRange()instead before node. Because node range doesn't include comments.Is there anything you'd like reviewers to focus on?
nothing