Fix: unicode-bom fixer insert BOM in appropriate location (fixes #8083)…

… (#8084) * Fix: unicode-bom fixer insert BOM in appropriate location (fixes #8083) * Fix: unicode-bom fixer insert BOM in appropriate location. Add test (refs #8083)
eslint · Feb 16, 2017 · c53e034 · c53e034
1 parent 55ac302
commit c53e034
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/rules/unicode-bom.js b/lib/rules/unicode-bom.js
@@ -45,7 +45,7 @@ module.exports = {
                         loc: location,
                         message: "Expected Unicode BOM (Byte Order Mark).",
                         fix(fixer) {
-                            return fixer.insertTextBefore(node, "\uFEFF");
+                            return fixer.insertTextBeforeRange([0, 1], "\uFEFF");
                         }
                     });
                 } else if (sourceCode.hasBOM && (requireBOM === "never")) {

diff --git a/tests/lib/rules/unicode-bom.js b/tests/lib/rules/unicode-bom.js
@@ -41,6 +41,12 @@ ruleTester.run("unicode-bom", rule, {
             options: ["always"],
             output: "\uFEFFvar a = 123;"
         },
+        {
+            code: " // here's a comment \nvar a = 123;",
+            errors: [{ message: "Expected Unicode BOM (Byte Order Mark).", type: "Program" }],
+            options: ["always"],
+            output: "\uFEFF // here's a comment \nvar a = 123;"
+        },
         {
             code: "\uFEFF var a = 123;",
             errors: [{ message: "Unexpected Unicode BOM (Byte Order Mark).", type: "Program" }],