Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: ensure semi-spacing checks import/export declarations #8033

Merged
merged 2 commits into from Feb 7, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

Tell us about your environment

  • ESLint Version: master
  • Node Version: 7.5.0
  • npm Version: 4.1.2

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

rules:
  semi-spacing: error
parserOptions:
  sourceType: module

What did you do? Please include the actual source code causing the issue.

import foo from 'bar' ;
export {foo} ;

What did you expect to happen?

I expected errors to be reported because there is space before the semicolons.

What actually happened? Please include the actual, raw output from ESLint.

No errors were reported.

What changes did you make? (Give an overview)

This updates semi-spacing to check the semicolon spacing for ImportDeclaration and ExportNamedDeclaration nodes.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules labels Feb 7, 2017
@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lo1tuma, @vitorbal and @alberto to be potential reviewers.

@eslintbot
Copy link

LGTM

@@ -206,6 +206,8 @@ module.exports = {
DebuggerStatement: checkNode,
ReturnStatement: checkNode,
ThrowStatement: checkNode,
ImportDeclaration: checkNode,
ExportNamedDeclaration: checkNode,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about ExportDefaultDeclaration and ExportAllDeclaration nodes?

@eslintbot
Copy link

LGTM

Copy link
Member

@alberto alberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alberto alberto merged commit f47fb98 into master Feb 7, 2017
@not-an-aardvark not-an-aardvark deleted the semi-spacing-imports branch February 7, 2017 06:19
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants