New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: ensure semi-spacing checks import/export declarations #8033
Conversation
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lo1tuma, @vitorbal and @alberto to be potential reviewers. |
LGTM |
@@ -206,6 +206,8 @@ module.exports = { | |||
DebuggerStatement: checkNode, | |||
ReturnStatement: checkNode, | |||
ThrowStatement: checkNode, | |||
ImportDeclaration: checkNode, | |||
ExportNamedDeclaration: checkNode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about ExportDefaultDeclaration
and ExportAllDeclaration
nodes?
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
I expected errors to be reported because there is space before the semicolons.
What actually happened? Please include the actual, raw output from ESLint.
No errors were reported.
What changes did you make? (Give an overview)
This updates
semi-spacing
to check the semicolon spacing forImportDeclaration
andExportNamedDeclaration
nodes.Is there anything you'd like reviewers to focus on?
Nothing in particular