Update: ensure semi-spacing checks import/export declarations (#8033)

* Update: ensure semi-spacing checks import/export declarations * Also check ExportAllDeclarations and ExportDefaultDeclarations
eslint · Feb 7, 2017 · f47fb98 · f47fb98
1 parent e228d56
commit f47fb98
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 1 deletion.
diff --git a/lib/rules/semi-spacing.js b/lib/rules/semi-spacing.js
@@ -206,6 +206,10 @@ module.exports = {
             DebuggerStatement: checkNode,
             ReturnStatement: checkNode,
             ThrowStatement: checkNode,
+            ImportDeclaration: checkNode,
+            ExportNamedDeclaration: checkNode,
+            ExportAllDeclaration: checkNode,
+            ExportDefaultDeclaration: checkNode,
             ForStatement(node) {
                 if (node.init) {
                     checkSemicolonSpacing(sourceCode.getTokenAfter(node.init), node);

diff --git a/tests/lib/rules/semi-spacing.js b/tests/lib/rules/semi-spacing.js
@@ -163,7 +163,51 @@ ruleTester.run("semi-spacing", rule, {
                 { message: "Unexpected whitespace after semicolon.", type: "ForStatement", line: 1, column: 15 },
                 { message: "Unexpected whitespace after semicolon.", type: "ForStatement", line: 1, column: 23 }
             ]
+        },
+        {
+            code: "import Foo from 'bar' ;",
+            output: "import Foo from 'bar';",
+            parserOptions: { sourceType: "module" },
+            options: [{ before: false, after: true }],
+            errors: [
+                { message: "Unexpected whitespace before semicolon.", type: "ImportDeclaration", line: 1, column: 23 }
+            ]
+        },
+        {
+            code: "import * as foo from 'bar' ;",
+            output: "import * as foo from 'bar';",
+            parserOptions: { sourceType: "module" },
+            options: [{ before: false, after: true }],
+            errors: [
+                { message: "Unexpected whitespace before semicolon.", type: "ImportDeclaration", line: 1, column: 28 }
+            ]
+        },
+        {
+            code: "export {foo} ;",
+            output: "export {foo};",
+            parserOptions: { sourceType: "module" },
+            options: [{ before: false, after: true }],
+            errors: [
+                { message: "Unexpected whitespace before semicolon.", type: "ExportNamedDeclaration", line: 1, column: 14 }
+            ]
+        },
+        {
+            code: "export * from 'foo' ;",
+            output: "export * from 'foo';",
+            parserOptions: { sourceType: "module" },
+            options: [{ before: false, after: true }],
+            errors: [
+                { message: "Unexpected whitespace before semicolon.", type: "ExportAllDeclaration", line: 1, column: 21 }
+            ]
+        },
+        {
+            code: "export default foo ;",
+            output: "export default foo;",
+            parserOptions: { sourceType: "module" },
+            options: [{ before: false, after: true }],
+            errors: [
+                { message: "Unexpected whitespace before semicolon.", type: "ExportDefaultDeclaration", line: 1, column: 20 }
+            ]
         }
-
     ]
 });