-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing arguments in examples #7068
Conversation
@mgedmin, thanks for your PR! By analyzing the annotation information on this pull request, we identified @keithamus, @aubergine10 and @IanVS to be potential reviewers |
Thanks for the pull request, @mgedmin! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
I apologize, but I'm not likely to find the time to read and agree to a CLA for this. I'm also surprised to be asked about an issue number for a documentation-only fix when your issue template said that wasn't necessary for documentation-only fixes. (Is your bot not smart enough to look at filenames in diffstat?) |
Hi @mgedmin, thank you for the PR! The bot is not smart enough to detect this change is only doc-related, so you can ignore that. The CLA is pretty short and straight-forward and as a bonus, signing it would mean you won't need to do it again for any project under the jQuery foundation. |
I'll definitely consider signing the CLA as soon as I have something serious to submit! (And I realize that filing #7069 probably took more time than it would've taken me to read the CLA, it's just that I haven't had breakfast yet and I can't force myself to deal with legalese.) |
Sorry about the confusion here. For documentation changes, you don't need an issue, but you do need to put "Docs:" at the front of your commit message. The bot is pretty dumb, but if it sees "Docs:", then it won't warn about needing an issue. We do need a CLA to accept any contributions, though, as it's part of our CI process. As @vitorbal pointed out, we do use the jQuery CLA, which is pretty straightforward and doesn't contain a lot of legalese. We are working on some changes to hopefully make what's expected more apparent to new contributors. |
What issue does this pull request address?
An error in documentation
What changes did you make? (Give an overview)
Added the missing function argument in Reflect.apply() calls
Is there anything you'd like reviewers to focus on?
Not really