Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing arguments in examples #7068

Closed
wants to merge 1 commit into from
Closed

Conversation

mgedmin
Copy link

@mgedmin mgedmin commented Sep 7, 2016

What issue does this pull request address?

An error in documentation

What changes did you make? (Give an overview)

Added the missing function argument in Reflect.apply() calls

Is there anything you'd like reviewers to focus on?

Not really

@mention-bot
Copy link

@mgedmin, thanks for your PR! By analyzing the annotation information on this pull request, we identified @keithamus, @aubergine10 and @IanVS to be potential reviewers

@eslintbot
Copy link

Thanks for the pull request, @mgedmin! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.
  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@mgedmin
Copy link
Author

mgedmin commented Sep 7, 2016

I apologize, but I'm not likely to find the time to read and agree to a CLA for this.

I'm also surprised to be asked about an issue number for a documentation-only fix when your issue template said that wasn't necessary for documentation-only fixes. (Is your bot not smart enough to look at filenames in diffstat?)

@vitorbal
Copy link
Member

vitorbal commented Sep 7, 2016

Hi @mgedmin, thank you for the PR! The bot is not smart enough to detect this change is only doc-related, so you can ignore that.

The CLA is pretty short and straight-forward and as a bonus, signing it would mean you won't need to do it again for any project under the jQuery foundation.
That said, if you still don't feel like taking the time to read and accept it, I understand.
Regardless, thank you for your contribution to ESLint.

@mgedmin
Copy link
Author

mgedmin commented Sep 7, 2016

I'll definitely consider signing the CLA as soon as I have something serious to submit!

(And I realize that filing #7069 probably took more time than it would've taken me to read the CLA, it's just that I haven't had breakfast yet and I can't force myself to deal with legalese.)

@nzakas
Copy link
Member

nzakas commented Sep 7, 2016

Sorry about the confusion here. For documentation changes, you don't need an issue, but you do need to put "Docs:" at the front of your commit message. The bot is pretty dumb, but if it sees "Docs:", then it won't warn about needing an issue.

We do need a CLA to accept any contributions, though, as it's part of our CI process. As @vitorbal pointed out, we do use the jQuery CLA, which is pretty straightforward and doesn't contain a lot of legalese.

We are working on some changes to hopefully make what's expected more apparent to new contributors.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants