Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation bug: missing Reflect.apply() argument in examples #7069

Closed
mgedmin opened this issue Sep 7, 2016 · 4 comments · Fixed by #7150
Closed

Documentation bug: missing Reflect.apply() argument in examples #7069

mgedmin opened this issue Sep 7, 2016 · 4 comments · Fixed by #7150
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation

Comments

@mgedmin
Copy link

mgedmin commented Sep 7, 2016

What version of ESLint are you using?

Not applicable.

What parser (default, Babel-ESLint, etc.) are you using?

Not applicable.

Please show your full configuration:

Not applicable.

What did you do? Please include the actual source code causing the issue.

Read the page at http://eslint.org/docs/rules/prefer-reflect

What did you expect to happen?

I expected the documentation examples of correct code to be correct, i.e. the first argument of Reflect.apply() to be a function.

What actually happened? Please include the actual, raw output from ESLint.

The first argument of Reflect.apply() is null or undefined in some of the examples:

ekrano nuotrauka is 2016-09-07 12-45-02

See also #7068.

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Sep 7, 2016
@vitorbal vitorbal added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Sep 7, 2016
@sstern6
Copy link
Contributor

sstern6 commented Sep 13, 2016

@vitorbal I can have a PR open for this today, should we simply remove the bad examples or replace the bad examples with new correct ones?

Thanks

@vitorbal
Copy link
Member

@sstern6 I think we should replace them with correct ones!

@sstern6
Copy link
Contributor

sstern6 commented Sep 13, 2016

@vitorbal will have it up for review this afternoon.

Thanks

@sstern6
Copy link
Contributor

sstern6 commented Sep 13, 2016

@vitorbal PR open and ready for review. Let me know if you need anything else.

Thanks

sstern6 added a commit to sstern6/eslint that referenced this issue Sep 27, 2016
sstern6 added a commit to sstern6/eslint that referenced this issue Sep 27, 2016
sstern6 added a commit to sstern6/eslint that referenced this issue Sep 28, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants