Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that space-infix-ops doesn't fail for Flow type annotations #6723

Merged
merged 2 commits into from Jul 22, 2016

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jul 20, 2016

What issue does this pull request address?
#5211 (continues work of #6519)

What changes did you make? (Give an overview)

Created a custom stub parser to test that type annotations will no longer trigger space-infix-ops.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

codepunkt and others added 2 commits June 23, 2016 15:07
Test fails and i have no clue how i'm supposed to add
`babel-eslint` to the testing stack for single tests.
@mention-bot
Copy link

@nzakas, thanks for your PR! By analyzing the annotation information on this pull request, we identified @gyandeeps, @vitorbal and @michaelficarra to be potential reviewers

@eslintbot
Copy link

Thanks for the pull request, @nzakas! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@ilyavolodin
Copy link
Member

LGTM, but waiting another day for others to look

@nzakas nzakas merged commit a2090cb into master Jul 22, 2016
@nzakas nzakas deleted the pr6519 branch July 22, 2016 19:03
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants