Fix: object-curly-spacing for type annotations (fixes #6940)
#6945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@mysticatea, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nzakas, @vitorbal and @pmcelhaney to be potential reviewers |
| * @returns {Token} '}' token. | ||
| */ | ||
| function getClosingBraceOfObject(node) { | ||
| const lastProperty = node.properties[node.properties.length - 1]; |
There was a problem hiding this comment.
Do we need to account for the possibility of node.properties.length === 0 here?
There was a problem hiding this comment.
No. It has been checked at the top of checkForObject function. So I just wrote it in the jsdoc comment.
|
Lgtm, just waiting another day so others can review. |
|
LGTM. |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6940.
This PR changes the way to find '}' token.
I followed #6723 about the way of tests.