Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode-bom fixer insert BOM in appropriate location #8083

Closed
pantosha opened this issue Feb 15, 2017 · 1 comment · Fixed by renovatebot/renovate#111 · May be fixed by iamhunter/teammates#4
Closed

unicode-bom fixer insert BOM in appropriate location #8083

pantosha opened this issue Feb 15, 2017 · 1 comment · Fixed by renovatebot/renovate#111 · May be fixed by iamhunter/teammates#4
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@pantosha
Copy link
Contributor

Tell us about your environment
Win 10, 64bit

  • ESLint Version: v.3.15.0
  • Node Version: v.7.5.0
  • npm Version: v.4.1.2
    What parser (default, Babel-ESLint, etc.) are you using?
    default
    Please show your full configuration:
"unicode-bom" :  "error"

What did you do? Please include the actual source code causing the issue.
I called eslint --fix some.js.

// Some comments.
function someFunction() {
    // some code...
}

What did you expect to happen?

<U+FEFF>// Some comments.
function someFunction() {
    // some code...
}

What actually happened? Please include the actual, raw output from ESLint.

// Some comments.
<U+FEFF><U+FEFF><U+FEFF><U+FEFF><U+FEFF><U+FEFF><U+FEFF><U+FEFF><U+FEFF><U+FEFF>function someFunction() {
    // some code...
}
@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Feb 15, 2017
@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Feb 15, 2017
@platinumazure
Copy link
Member

@pantosha Looks like this is happening due to multipass autofix (and not detecting that the BOM was already inserted in a previous run). Thanks for reporting this!

pantosha added a commit to pantosha/eslint that referenced this issue Feb 15, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
4 participants