Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testem: Use --no-sandbox on TravisCI #7566

Merged
merged 3 commits into from Jan 21, 2018
Merged

testem: Use --no-sandbox on TravisCI #7566

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67525d1
testem: Use `--no-sandbox` on TravisCI
Turbo87 Jan 21, 2018
d3297fd
testem: Adjust test configs
Turbo87 Jan 21, 2018
92774e7
tests/acceptance: Update test number expectation
Turbo87 Jan 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion blueprints/app/files/testem.js
View file
Open in desktop
Expand Up @@ -11,11 +11,14 @@ module.exports = {
Chrome: {
mode: 'ci',
args: [
// --no-sandbox is needed when running Chrome inside a container
process.env.TRAVIS ? '--no-sandbox' : null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use process.env.CI instead? As I understand it a number of CI providers have this same basic issues (e.g. GitLab CI), and the CI environment flag is pretty universal...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure... GitLab CI can and often does use Docker containers, but you can also run it on real hosts, AppVeyor is likely VM-based, so there are also some CI systems that do not run in containers. The condition is easy enough to adjust if needed 🤔


'--disable-gpu',
'--headless',
'--remote-debugging-port=0',
'--window-size=1440,900'
]
].filter(Boolean)
}
}
};