testem: Use --no-sandbox on TravisCI
#7566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Jan 21, 2018
| @@ -11,11 +11,14 @@ module.exports = { | |||
| Chrome: { | |||
| mode: 'ci', | |||
| args: [ | |||
| // --no-sandbox is needed when running Chrome inside a container | |||
| process.env.TRAVIS ? '--no-sandbox' : null, | |||
There was a problem hiding this comment.
Should we use process.env.CI instead? As I understand it a number of CI providers have this same basic issues (e.g. GitLab CI), and the CI environment flag is pretty universal...
There was a problem hiding this comment.
I'm not sure... GitLab CI can and often does use Docker containers, but you can also run it on real hosts, AppVeyor is likely VM-based, so there are also some CI systems that do not run in containers. The condition is easy enough to adjust if needed 🤔
|
Nice, thanks for looking into this. I figured the sandbox was desirable for some reason? haha oops |
`ember-qunit` is now generating a test of its own which we did not expect before. Updating the expected number of tests fixes our CI runs.
|
FYI I had to include two more commits to make CI pass on the |
This was referenced Jan 22, 2018
dunnkers
added a commit
to dunnkers/ember-polymer
that referenced
this pull request
Jan 22, 2018
Related to use of Headless Chrome, see ember-cli/ember-cli#7566.
dunnkers
added a commit
to dunnkers/ember-polymer-paper
that referenced
this pull request
Jan 22, 2018
Related to use of Headless Chrome, see ember-cli/ember-cli#7566.
mrloop
added a commit
to mrloop/race-ext
that referenced
this pull request
Jan 29, 2018
This was referenced Jan 30, 2018
mrloop
added a commit
to mrloop/ember-retry
that referenced
this pull request
Feb 21, 2018
cyk
added a commit
to cyk/ember-cli
that referenced
this pull request
Jun 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to ember-cli/ember-cli-chai#45 this updates the
testem.jsfile of theappblueprint to run Chrome with--no-sandboxwhen used on TravisCI to avoid travis-ci/travis-ci#8836/cc @backspace