Fix dirty git state #6911
Merged
Fix dirty git state #6911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clekstro
force-pushed
the
fix-dirty-git-state
branch
from
62cbef3
to
2ac2ce0
Compare
|
looks like this was caused by myself in #5797 |
Turbo87
approved these changes
Mar 27, 2017
homu
added a commit
that referenced
this pull request
Mar 28, 2017
Stop creating recursive symlink (addon requiring itself) When running the `addon/smoke-test-slow` test in isolation, I was getting an `EEXIST` error that the `node_modules/developing-addon` symlink that we were creating manually in this test is already present. Deleting the extra test setup resolved the issue. This just impacts the test suite and was a precursor to #6911. Many thanks to @Turbo87 for helping to track this down ❤️
|
@homu r+ |
|
📌 Commit 2ac2ce0 has been approved by |
homu
added a commit
that referenced
this pull request
Mar 28, 2017
Fix dirty git state This fixes #6909. Inside of the `afterInstall` hook, we were using the async methods of fs-extra (`.remove()`) but not actually waiting for them to resolve. Instead, we use the sync variant to resolve the issue, as this ensures the file has been removed before we proceed.
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6909. Inside of the
afterInstallhook, we were using the async methods of fs-extra (.remove()) but not actually waiting for them to resolve. Instead, we use the sync variant to resolve the issue, as this ensures the file has been removed before we proceed.