Use const/let in all blueprints #6889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look good. I agree with the Not sure why the tests are failing, might need to dig into the travis output to see... |
|
@rwjblue The two failing tests are the ones I was mentioning above, requiring the changes in ember-cli/ember-cli-blueprint-test-helpers#104 to succeed. Once there is a new release of |
|
@simonihmig I just published v0.17.1 of the blueprint-test-helpers |
|
@homu r+ |
|
📌 Commit 8422900 has been approved by |
Turbo87
changed the title
homu
added a commit
that referenced
this pull request
Mar 24, 2017
Use const/let in all blueprints This will remove all left over usage of `var` off the blueprints. When to use `const` vs. `let` is a matter of opinions obviously. After checking with @Turbo87 on Slack, I was assuming the `ember-suave`-like rules of `const` in module root, `let` otherwise would be appropriate. Although in some cases we have `require` statements in a function body, so used `const` there as well. Hope that makes sense... There will be some test failures, as this is relying on ember-cli/ember-cli-blueprint-test-helpers#104 to be merged and released. So don't merge yet!
|
💔 Test failed - status |
|
@homu retry |
homu
added a commit
that referenced
this pull request
Mar 24, 2017
Use const/let in all blueprints This will remove all left over usage of `var` off the blueprints. When to use `const` vs. `let` is a matter of opinions obviously. After checking with @Turbo87 on Slack, I was assuming the `ember-suave`-like rules of `const` in module root, `let` otherwise would be appropriate. Although in some cases we have `require` statements in a function body, so used `const` there as well. Hope that makes sense... There will be some test failures, as this is relying on ember-cli/ember-cli-blueprint-test-helpers#104 to be merged and released. So don't merge yet!
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove all left over usage of
varoff the blueprints.When to use
constvs.letis a matter of opinions obviously. After checking with @Turbo87 on Slack, I was assuming theember-suave-like rules ofconstin module root,letotherwise would be appropriate. Although in some cases we haverequirestatements in a function body, so usedconstthere as well. Hope that makes sense...There will be some test failures, as this is relying on ember-cli/ember-cli-blueprint-test-helpers#104 to be merged and released. So don't merge yet!