Replace lib/utilities/DAG.js with dag-map package #6890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
changed the title
rwjblue
previously requested changes
Mar 23, 2017
package.json
Outdated
| @@ -129,6 +129,7 @@ | |||
| "chai-as-promised": "^6.0.0", | |||
| "chai-files": "^1.2.0", | |||
| "co": "^4.6.0", | |||
| "dag-map": "^2.0.2", | |||
There was a problem hiding this comment.
This should be a dependency, not a devDep (it is used for normal app runtime).
There was a problem hiding this comment.
Sorry about that, just moved to deps!
Turbo87
approved these changes
Mar 24, 2017
|
@homu r+ thanks @rwwagner90! |
|
📌 Commit 141b2c5 has been approved by |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 141b2c5 has been approved by |
|
💡 This pull request was already approved, no need to approve it again.
|
homu
added a commit
that referenced
this pull request
Mar 24, 2017
Replace lib/utilities/DAG.js with dag-map package Resolves #6881
|
💔 Test failed - status |
|
@homu retry @rwjblue @stefanpenner we seem to have introduced quite a bit of flakiness to our tests again... 🤔 |
homu
added a commit
that referenced
this pull request
Mar 24, 2017
Replace lib/utilities/DAG.js with dag-map package Resolves #6881
|
💔 Test failed - status |
|
@homu retry 😠 |
homu
added a commit
that referenced
this pull request
Mar 24, 2017
Replace lib/utilities/DAG.js with dag-map package Resolves #6881
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6881