Prevent clobbering custom this.options.babel
#190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `this.options` inside of `included` to the options from `lib/broccoli/ember-app` means that we will attempt to transpile with the `options.babel` that the host app / addon is using. Which, as of, 2.13+ that will be babel@6 and therefore incompatible options with ember-cli-babel@5 (which this addon uses).
|
Travis agrees, merging! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
this.optionsinside ofincludedto the options fromlib/broccoli/ember-appmeans that we will attempt to transpile with theoptions.babelthat the host app / addon is using. Which, as of, 2.13+ that will be babel@6 and therefore incompatible options with ember-cli-babel@5 (which this addon uses).Resolves #182