Not compatible with ember-cli@2.13 #182

simonexmachina · 2017-03-23T01:52:39Z

I just created a clean test project with ember-cli@2.13 using ember new ember-test --yarn then ran ember install ember-cli-mocha and now ember s fails with the following error message:

$ ember s
Livereload server on http://localhost:49153
File: ember-mocha.js
The Broccoli Plugin: [broccoli-persistent-filter:Babel > [Babel: Ember CLI Mocha]: Babel: Ember CLI Mocha] failed with:
TypeError: The plugin [null,{}] didn't export a Plugin instance
    at PluginManager.validate (/Users/simonwade/Temp/test-ember/node_modules/babel-core/lib/transformation/file/plugin-manager.js:164:13)
    at PluginManager.add (/Users/simonwade/Temp/test-ember/node_modules/babel-core/lib/transformation/file/plugin-manager.js:213:10)
    at File.buildTransformers (/Users/simonwade/Temp/test-ember/node_modules/babel-core/lib/transformation/file/index.js:237:21)
    at new File (/Users/simonwade/Temp/test-ember/node_modules/babel-core/lib/transformation/file/index.js:139:10)
    at Pipeline.transform (/Users/simonwade/Temp/test-ember/node_modules/babel-core/lib/transformation/pipeline.js:164:16)
    at Babel.transform (/Users/simonwade/Temp/test-ember/node_modules/ember-cli-mocha/node_modules/broccoli-babel-transpiler/index.js:107:21)
    at Babel.processString (/Users/simonwade/Temp/test-ember/node_modules/ember-cli-mocha/node_modules/broccoli-babel-transpiler/index.js:206:25)
    at Promise.then.result.output (/Users/simonwade/Temp/test-ember/node_modules/broccoli-persistent-filter/lib/strategies/persistent.js:41:23)
    at initializePromise (/Users/simonwade/Temp/test-ember/node_modules/rsvp/dist/rsvp.js:589:5)
    at new Promise$1 (/Users/simonwade/Temp/test-ember/node_modules/rsvp/dist/rsvp.js:1077:33)

The broccoli plugin was instantiated at:
    at Babel.Plugin (/Users/simonwade/Temp/test-ember/node_modules/broccoli-plugin/index.js:7:31)
    at Babel.Filter [as constructor] (/Users/simonwade/Temp/test-ember/node_modules/broccoli-persistent-filter/index.js:62:10)
    at new Babel (/Users/simonwade/Temp/test-ember/node_modules/ember-cli-mocha/node_modules/broccoli-babel-transpiler/index.js:35:10)
    at Babel (/Users/simonwade/Temp/test-ember/node_modules/ember-cli-mocha/node_modules/broccoli-babel-transpiler/index.js:30:12)
    at Object.toTree (/Users/simonwade/Temp/test-ember/node_modules/ember-cli-mocha/node_modules/ember-cli-babel/index.js:30:52)
    at /Users/simonwade/Temp/test-ember/node_modules/ember-cli-preprocess-registry/preprocessors.js:180:26
    at Array.forEach (native)
    at processPlugins (/Users/simonwade/Temp/test-ember/node_modules/ember-cli-preprocess-registry/preprocessors.js:178:11)
    at Function.module.exports.preprocessJs (/Users/simonwade/Temp/test-ember/node_modules/ember-cli-preprocess-registry/preprocessors.js:171:10)
    at Class.preprocessJs (/Users/simonwade/Temp/test-ember/node_modules/ember-cli/lib/models/addon.js:1104:25)

The text was updated successfully, but these errors were encountered:

rwjblue · 2017-03-23T02:07:07Z

What is your environment? Is this under npm@2, npm@3, yarn, etc? What node version?

rwjblue · 2017-03-23T02:07:49Z

Can you push up a demo app, including node_modules, so we can take a look at what is going on?

simonexmachina · 2017-03-23T02:13:55Z

Sorry, I should have indicated I used ember new test-ember --yarn with yarn@0.18.1 and node@7.6.0.

simonexmachina · 2017-03-23T02:16:23Z

Pushing to https://github.com/aexmachina/ember-cli-mocha-182...

simonexmachina · 2017-03-23T02:19:37Z

That's pushed now

Turbo87 · 2017-03-23T08:01:56Z

I can reproduce this with just:

ember new foo --yarn
cd foo
ember install ember-cli-mocha
ember serve

@aexmachina thanks for the reproduction!

Turbo87 · 2017-03-23T08:08:52Z

$ yarn list broccoli-babel-transpiler
yarn list v0.21.3
├─ broccoli-babel-transpiler@5.6.2
├─ ember-cli-babel@6.0.0-beta.9
│  └─ broccoli-babel-transpiler@6.0.0
├─ ember-cli@2.13.0-beta.2
│  └─ broccoli-babel-transpiler@6.0.0-alpha.3
└─ ember-data@2.13.0-beta.3
│  └─ broccoli-babel-transpiler@6.0.0

$ yarn why broccoli-babel-transpiler
yarn why v0.21.3
[1/4] 🤔  Why do we have the module "broccoli-babel-transpiler"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
info Has been hoisted to "broccoli-babel-transpiler"
info Reasons this module exists
   - "ember-cli-mocha" depends on it
   - "ember-ajax#ember-cli-babel" depends on it
info Disk size without dependencies: "13.14MB"
info Disk size with unique dependencies: "13.72MB"
info Disk size with transitive dependencies: "34.59MB"
info Amount of shared dependencies: 79

This seems to be an issue inside of Ember CLI. After yarn add ember-cli@2.12.1 everything builds and runs fine again.

rwjblue · 2017-04-01T00:22:24Z

Good news!! I have determined the issue here...

It comes down to issues with npm non-determinism. I have a solution, but it will involve fixes upstream in ember-cli.

Turbo87 · 2017-04-01T00:40:52Z

cool, thanks!

stefanpenner · 2017-04-17T20:01:32Z

I have a solution

Just spoke to @rwjblue, the solution is:

No longer trust npm to do npm install <package>, because they appear to only consider <package> dependencies, not the full graph. They bork stuff up. We should confirm that latest yarn has or doesn't have this problem. If it does, the solution for us would be either:

do nothing, tell people to rimraf node_modules and try again
on packageInstall manually update package.json to include the new or updated version, and then run npm install. <-- @rwjblue's solution

stefanpenner · 2017-04-17T20:02:01Z

@Turbo87 I suspect we want to do the second one, as this will give a better user experience. What are your thoughts?

Turbo87 · 2017-04-17T20:38:16Z

@stefanpenner I'm not yet convinced that this is actually the issue or solution. I'd be very surprised if npm would be that broken. I'm instead suspecting that something is not resolving from the correct cwd.

Turbo87 · 2017-04-17T20:39:37Z

Also I had the same issue with yarn, and yarn is supposed to have stable output which seems to be another hint that something else might be wrong.

stefanpenner · 2017-04-17T21:04:37Z

@Turbo87 ah, ok. So it sounds like this needs more exploration?

Turbo87 · 2017-04-18T07:01:51Z

it sounds like this needs more exploration?

yes. the problem is that I am not aware of what could have caused this to break in Ember CLI itself since it all works fine with the v2.12 releases.

runspired · 2017-04-18T14:56:20Z

I'd be very surprised if npm would be that broken. I'm instead suspecting that something is not resolving from the correct cwd.

npm is that broken, I deal with this particular bug often. The solution to manually add to package.json and then run npm install should work, but I often find myself going for the more nuclear option (also mentioned above) of rm -rf node_modules prior to install.

runspired · 2017-04-18T14:59:03Z

Also, fwiw, I've noticed this in prior ember-cli releases, but it's become more problematic recently because of the babel6 upgrade and a few other dependency bumps. I don't think this is an issue with ember-cli because I have been able manually recreate this problem without the involvement of any cli commands.

Turbo87 · 2017-04-18T15:44:32Z

npm is that broken, I deal with this particular bug often

what particular bug are you talking about? I'm not sure we're all talking about the same things here...

I don't think this is an issue with ember-cli

since downgrading ember-cli to v2.12 solves the issue I'm pretty sure it is an issue in ember-cli or at least surfaced by ember-cli v2.13-beta

kevinansfield · 2017-04-21T15:44:51Z

I've tried upgrading Ghost to ember-cli v2.13-beta.3 to test and have also run into this issue.

yarn: v0.23.2
node: v6.10.1 (alto tested with with same issue on v4.8.1)

rm -rf node_modules && yarn install made no difference

If there's any other info I can provide to help track the issue down please let me know. My test branch is here if it's of any use

Turbo87 · 2017-04-21T21:07:17Z

result of git bisect looks a little confusing to me... 🤔

fddbc4a111bb2ec57170e2648a5fc37e2036c422 is the first bad commit
commit fddbc4a111bb2ec57170e2648a5fc37e2036c422
Author: Tobias Bieniek <tobias.bieniek@gmail.com>
Date:   Thu Mar 16 13:00:23 2017 +0100

    Release v2.13.0-beta.1

rwjblue · 2017-04-21T21:42:00Z

Submitted the fix in #190

simonexmachina · 2017-04-24T01:38:27Z

Thanks @rwjblue 👍

Turbo87 added the bug label Mar 23, 2017

Turbo87 assigned rwjblue Mar 31, 2017

Turbo87 mentioned this issue Apr 17, 2017

Ember CLI 2.13.0 Blockers ember-cli/ember-cli#6959

Closed

3 tasks

rwjblue mentioned this issue Apr 21, 2017

Prevent clobbering custom this.options.babel #190

Merged

Turbo87 closed this as completed in #190 Apr 21, 2017

notmessenger mentioned this issue Jul 14, 2017

Error when installed into an app running v2.14.1 of Ember ciena-frost/ember-frost-core#474

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Not compatible with ember-cli@2.13 #182

Not compatible with ember-cli@2.13 #182

simonexmachina commented Mar 23, 2017 •

edited

rwjblue commented Mar 23, 2017

rwjblue commented Mar 23, 2017

simonexmachina commented Mar 23, 2017

simonexmachina commented Mar 23, 2017

simonexmachina commented Mar 23, 2017

Turbo87 commented Mar 23, 2017 •

edited

Turbo87 commented Mar 23, 2017 •

edited

rwjblue commented Apr 1, 2017

Turbo87 commented Apr 1, 2017

stefanpenner commented Apr 17, 2017 •

edited

stefanpenner commented Apr 17, 2017

Turbo87 commented Apr 17, 2017

Turbo87 commented Apr 17, 2017

stefanpenner commented Apr 17, 2017

Turbo87 commented Apr 18, 2017

runspired commented Apr 18, 2017

runspired commented Apr 18, 2017

Turbo87 commented Apr 18, 2017

kevinansfield commented Apr 21, 2017

Turbo87 commented Apr 21, 2017

rwjblue commented Apr 21, 2017

simonexmachina commented Apr 24, 2017

Not compatible with ember-cli@2.13 #182

Not compatible with ember-cli@2.13 #182

Comments

simonexmachina commented Mar 23, 2017 • edited

rwjblue commented Mar 23, 2017

rwjblue commented Mar 23, 2017

simonexmachina commented Mar 23, 2017

simonexmachina commented Mar 23, 2017

simonexmachina commented Mar 23, 2017

Turbo87 commented Mar 23, 2017 • edited

Turbo87 commented Mar 23, 2017 • edited

rwjblue commented Apr 1, 2017

Turbo87 commented Apr 1, 2017

stefanpenner commented Apr 17, 2017 • edited

stefanpenner commented Apr 17, 2017

Turbo87 commented Apr 17, 2017

Turbo87 commented Apr 17, 2017

stefanpenner commented Apr 17, 2017

Turbo87 commented Apr 18, 2017

runspired commented Apr 18, 2017

runspired commented Apr 18, 2017

Turbo87 commented Apr 18, 2017

kevinansfield commented Apr 21, 2017

Turbo87 commented Apr 21, 2017

rwjblue commented Apr 21, 2017

simonexmachina commented Apr 24, 2017

simonexmachina commented Mar 23, 2017 •

edited

Turbo87 commented Mar 23, 2017 •

edited

Turbo87 commented Mar 23, 2017 •

edited

stefanpenner commented Apr 17, 2017 •

edited