Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server-side-image-map): return as needs review rather than failure #1898

Merged
merged 1 commit into from Nov 13, 2019
Merged

fix(server-side-image-map): return as needs review rather than failure #1898

merged 1 commit into from Nov 13, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Nov 13, 2019 •
edited by WilcoFiers

What should the remediation message be for this?

Closes issue: #408

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner November 13, 2019 18:17
@straker straker merged commit d544856 into develop Nov 13, 2019
@straker straker deleted the serverSideImgMap branch November 13, 2019 20:35
straker added a commit that referenced this pull request Dec 11, 2019
@straker
fix(server-side-image-map): return as needs review rather than failure (
ce73af9 
#1898)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@straker @WilcoFiers