Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server-side-image-map): return as needs review rather than failure #1898

Merged
merged 1 commit into from
Nov 13, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/checks/shared/exists.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
return true;
return undefined;
2 changes: 1 addition & 1 deletion lib/checks/shared/exists.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"impact": "minor",
"messages": {
"pass": "Element does not exist",
"fail": "Element exists"
"incomplete": "Element exists"
}
}
}
4 changes: 2 additions & 2 deletions test/checks/shared/exists.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
describe('exists', function() {
'use strict';

it('should return true', function() {
assert.isTrue(checks.exists.evaluate());
it('should return undefined', function() {
assert.isUndefined(checks.exists.evaluate());
});
});
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<p><img ismap src="image.jpg" id="fail" /></p>
<p><img ismap src="image.jpg" id="incomplete" /></p>
<p><img src="image.jpg" id="pass" /></p>
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"description": "server-side-image-map test",
"rule": "server-side-image-map",
"violations": [["#fail"]]
"incomplete": [["#incomplete"]]
}