fix(server-side-image-map): return as needs review rather than failure (

#1898)
dequelabs · Nov 13, 2019 · d544856 · d544856
1 parent ac70a16
commit d544856
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/lib/checks/shared/exists.js b/lib/checks/shared/exists.js
@@ -1 +1 @@
-return true;
+return undefined;
diff --git a/lib/checks/shared/exists.json b/lib/checks/shared/exists.json
@@ -5,7 +5,7 @@
 		"impact": "minor",
 		"messages": {
 			"pass": "Element does not exist",
-			"fail": "Element exists"
+			"incomplete": "Element exists"
 		}
 	}
 }
diff --git a/test/checks/shared/exists.js b/test/checks/shared/exists.js
@@ -1,7 +1,7 @@
 describe('exists', function() {
 	'use strict';
 
-	it('should return true', function() {
-		assert.isTrue(checks.exists.evaluate());
+	it('should return undefined', function() {
+		assert.isUndefined(checks.exists.evaluate());
 	});
 });
diff --git a/test/integration/rules/server-side-image-map/server-side-image-map.html b/test/integration/rules/server-side-image-map/server-side-image-map.html
@@ -1,2 +1,2 @@
-<p><img ismap src="image.jpg" id="fail" /></p>
+<p><img ismap src="image.jpg" id="incomplete" /></p>
 <p><img src="image.jpg" id="pass" /></p>
diff --git a/test/integration/rules/server-side-image-map/server-side-image-map.json b/test/integration/rules/server-side-image-map/server-side-image-map.json
@@ -1,5 +1,5 @@
 {
 	"description": "server-side-image-map test",
 	"rule": "server-side-image-map",
-	"violations": [["#fail"]]
+	"incomplete": [["#incomplete"]]
 }