fix: input[role=button][value='correct'] should pass (#1897)

dequelabs · Nov 14, 2019 · 4635fef · 4635fef
1 parent d544856
commit 4635fef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/rules/button-name.json b/lib/rules/button-name.json
@@ -1,6 +1,6 @@
 {
 	"id": "button-name",
-	"selector": "button, [role=\"button\"]",
+	"selector": "button, [role=\"button\"]:not(input)",
 	"tags": [
 		"cat.name-role-value",
 		"wcag2a",
@@ -22,4 +22,4 @@
 		"non-empty-title"
 	],
 	"none": []
-}
+}
diff --git a/test/integration/rules/button-name/button-name.html b/test/integration/rules/button-name/button-name.html
@@ -11,3 +11,5 @@
 <button id="combo" aria-label="Aria Name">Name</button>
 <button id="buttonTitle" title="Title"></button>
 <button id="buttonvalue" value="foo" tabindex="-1"></button>
+
+<input type="submit" value="submit" role="button" id="ignored" />