Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add free plan seats alert #2840

Merged
merged 2 commits into from
May 13, 2024
Merged

feat: Add free plan seats alert #2840

merged 2 commits into from
May 13, 2024

Conversation

RulaKhaled
Copy link
Contributor

Description

Problem: Users view a general error of "unauthorized error" if they can't view the page
Solution: Seat limit reach screen

Conditions to render: User is not activated, viewing private repo, on paid plans, no seats left.

Notable Changes

  • Create activation alert which is what will determine what alert to render
  • Create alert for free plan users

Screenshots

Screenshot 2024-05-06 at 12 53 49 PM

closes: codecov/engineering-team#1316

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (5571e7c) to head (c7ed80c).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2840   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         875      877    +2     
  Lines       12932    12941    +9     
  Branches     3444     3469   +25     
=======================================
+ Hits        12736    12745    +9     
  Misses        192      192           
  Partials        4        4           
Files Coverage Δ
...pages/RepoPage/ActivationAlert/ActivationAlert.tsx 100.00% <100.00%> (ø)
...reePlanSeatsTakenAlert/FreePlanSeatsTakenAlert.tsx 100.00% <100.00%> (ø)
...nauthorizedRepoDisplay/UnauthorizedRepoDisplay.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPage.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.27% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5571e7c...c7ed80c. Read the comment docs.

Copy link

codecov-public-qa bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (5571e7c) to head (c7ed80c).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2840   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         875      877    +2     
  Lines       12932    12941    +9     
  Branches     3462     3446   -16     
=======================================
+ Hits        12736    12745    +9     
  Misses        192      192           
  Partials        4        4           
Files Coverage Δ
...pages/RepoPage/ActivationAlert/ActivationAlert.tsx 100.00% <100.00%> (ø)
...reePlanSeatsTakenAlert/FreePlanSeatsTakenAlert.tsx 100.00% <100.00%> (ø)
...nauthorizedRepoDisplay/UnauthorizedRepoDisplay.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPage.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.27% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5571e7c...c7ed80c. Read the comment docs.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.49%. Comparing base (5571e7c) to head (c7ed80c).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2840     +/-   ##
=======================================
+ Coverage   98.48   98.49   +0.01     
=======================================
  Files        875     877      +2     
  Lines      12932   12941      +9     
  Branches    3444    3464     +20     
=======================================
+ Hits       12736   12745      +9     
  Misses       192     192             
  Partials       4       4             
Files Coverage Δ
...pages/RepoPage/ActivationAlert/ActivationAlert.tsx 100.00% <100.00%> (ø)
...reePlanSeatsTakenAlert/FreePlanSeatsTakenAlert.tsx 100.00% <100.00%> (ø)
...nauthorizedRepoDisplay/UnauthorizedRepoDisplay.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPage.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.27% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5571e7c...c7ed80c. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented May 6, 2024

Bundle Report

Changes will increase total bundle size by 31.63kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.61MB 31.63kB ⬆️

Copy link

codecov bot commented May 6, 2024

Bundle Report

Changes will increase total bundle size by 31.63kB ⬆️

Bundle name Size Change
gazebo-production-array-push 6.61MB 31.63kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented May 6, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
5dcfbbe Mon, 06 May 2024 11:34:50 GMT Expired Expired
c7ed80c Mon, 13 May 2024 14:01:01 GMT Cloud Enterprise

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2840   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         875      877    +2     
  Lines       12932    12941    +9     
  Branches     3401     3464   +63     
=======================================
+ Hits        12736    12745    +9     
  Misses        192      192           
  Partials        4        4           
Files Coverage Δ
...pages/RepoPage/ActivationAlert/ActivationAlert.tsx 100.00% <100.00%> (ø)
...reePlanSeatsTakenAlert/FreePlanSeatsTakenAlert.tsx 100.00% <100.00%> (ø)
...nauthorizedRepoDisplay/UnauthorizedRepoDisplay.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPage.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.27% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5571e7c...c7ed80c. Read the comment docs.

@RulaKhaled RulaKhaled added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 3ccb37c May 13, 2024
60 checks passed
@RulaKhaled RulaKhaled deleted the free-plan-seats-alert branch May 13, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gazebo] Display a new error on the repo page for PAID plans when all seats are taken
3 participants