feat: Create alert for paid plans #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2841 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 877 879 +2
Lines 12941 12951 +10
Branches 3469 3407 -62
=======================================
+ Hits 12745 12755 +10
Misses 192 192
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2841 +/- ##
=====================================
Coverage 98.49 98.49
=====================================
Files 877 879 +2
Lines 12941 12951 +10
Branches 3403 3408 +5
=====================================
+ Hits 12745 12755 +10
Misses 192 192
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2841 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 877 879 +2
Lines 12941 12951 +10
Branches 3464 3468 +4
=======================================
+ Hits 12745 12755 +10
Misses 192 192
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 1.67kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 1.67kB ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
* update usePrefetchBranchDirEntry * update useRepoBranchContents * update index file * update query off of repositoryDeprecated * update tests * small change to have commit signed * update constants to ts * small tweaks to the query keys
…ositoryDeprecated (#2843)
* feat: Add activation banner for trial eligible owners * pull out interface + spec stuff * Update to reflect paid plan activation banner * Refactor CircleCI repo onboarding into one file (#2806) * Refactor Other CI repo onboarding into one file (#2807) * Update repo onboarding title position and page alignment (#2818) * sec: 390 - Add validation for potential XSS vuln (#2797) * add tests, and validation for provider * add back supportServiceless param * ref: 1548 Part 1: Convert all Header files to TS (#2821) * ref all header files to TS * remove prop types and rebase * fix: Remove repository from GUT settings page header (#2823) Small tweak removing `repository` from the GUT settings page. * Install radix-ui react radio group (#2825) * Update repo onboarding steps with new Card component (#2819) GH codecov/engineering-team#1665 * feat: Add hasSeatsLeft to plan query * Update to reflect SeatsLimitReachedBanner * feat: paid plan activation banner * update with from FreePlanSeatsLimitBanner * value duplicate * feat: paid plan seats limit banner * just one more small tweak * update name to FreePlanSeatsLimitBanner * remove queryclient call * update tests * fix padding * Update to have a const for plan value --------- Co-authored-by: Spencer Murray <159931558+spalmurray-codecov@users.noreply.github.com> Co-authored-by: ajay-sentry <159853603+ajay-sentry@users.noreply.github.com> Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io>
* feat: Add activation banner for trial eligible owners * pull out interface + spec stuff * Update to reflect paid plan activation banner * Refactor CircleCI repo onboarding into one file (#2806) * Refactor Other CI repo onboarding into one file (#2807) * Update repo onboarding title position and page alignment (#2818) * sec: 390 - Add validation for potential XSS vuln (#2797) * add tests, and validation for provider * add back supportServiceless param * ref: 1548 Part 1: Convert all Header files to TS (#2821) * ref all header files to TS * remove prop types and rebase * fix: Remove repository from GUT settings page header (#2823) Small tweak removing `repository` from the GUT settings page. * Install radix-ui react radio group (#2825) * Update repo onboarding steps with new Card component (#2819) GH codecov/engineering-team#1665 * feat: Add hasSeatsLeft to plan query * Update to reflect SeatsLimitReachedBanner * feat: paid plan activation banner * update with from FreePlanSeatsLimitBanner * value duplicate * feat: Activation required banner * clean up previous commit * match design * fix style * Resolve conflicts --------- Co-authored-by: Spencer Murray <159931558+spalmurray-codecov@users.noreply.github.com> Co-authored-by: ajay-sentry <159853603+ajay-sentry@users.noreply.github.com> Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io>
…2844) * Convert UseCommitYaml to Repository from RepositoryDeprecated * Update query key
…2847) * init conversion and remove deprecated, testing * fix tests for useCommitErrors * add additional spec * add dev stuff * update test coverage
* add plan route logic if to param set as plan * help w/ test * remove some unneeded mocks * remove to * fix spec mocks
* fill color update * update hex val
* Update usereposettings * Update tests * update test * Update more tests * Update more tests * more test updates * Update type * Update * Update query * Refactor
* pin @sentry/react to the latest release candidated * update lockfile
* Fix coverage tab file list table * Fix coverage tab code tree table tests * Fix pull indirect changed files table * Fix commit file explorer table * Fix missed instance of getByText
* Convert Access.jsx -> tsx * Fix type issue with TokensTable * Remove unnecessary import * Convert SessionsTable to ts * Add tests * Fix tests * Fix all testLocation: any * Use msw for mutation mock * Improve flatmap callback for readability * Better type hint for flat map return * Fix flake * Fix imports * Fix indirect coverage loss
* Fix copy pasta border/padding * Page width change * Vite onboarding overhaul * Webpack onboarding overhaul * Rollup onboarding overhaul * Fix tests
…ds (#2865) * Update to 8 uploads before comment to avoid many comments * Oopsie it's actually the ceiling
…oryDeprecated (#2857) * fix tests, confirm it works * export type and use instead
* Use RadioTileGroup for navigation on the repo onboarding page * Pull getInitalProvider out of component * Fix tests * Remove unnecessary div
* Clean up pull file explorer tests * Fix tests * Revert "Fix tests" This reverts commit f5aeccd.
#2869) * Fix responsiveness issue on RadioTileGroup * Add longer description to story * Left align the label text
* update usePrefetchSingleFileComp to TS * update NameColumn tests * move fragment schema next to gql fragment string
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2841 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 877 879 +2
Lines 12941 12951 +10
Branches 3404 3468 +64
=======================================
+ Hits 12745 12755 +10
Misses 192 192
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
| @@ -3,6 +3,9 @@ import { useParams } from 'react-router-dom' | |||
| import { usePlanData } from 'services/account' | |||
| import { isFreePlan } from 'shared/utils/billing' | |||
|
|
|||
| import ActivationRequiredAlert from './ActivationRequiredAlert' | |||
| import FreePlanSeatsTakenAlert from './FreePlanSeatsTakenAlert' | |||
| import PaidPlanSeatsTakenAlert from './PaidPlanSeatsTakenAlert' | |||
There was a problem hiding this comment.
might be a leftover from a merge
rohitvinnakota-codecov
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The two scenarios handled here are:
Paid plan, no seats left
Paid plan, some seats left
feat: Add free plan seats alert #2840
Notable Changes
Screenshots
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.