Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tabs style in card mode #15299

Merged
merged 1 commit into from Mar 9, 2019
Merged

fix tabs style in card mode #15299

merged 1 commit into from Mar 9, 2019

Conversation

rinick
Copy link
Contributor

@rinick rinick commented Mar 9, 2019

🤔 This is a ...

  • Bug fix

👻 What's the background?

resolves issue #15297 card mode tabs component style is broken when browser scale is not 100%

💡 Solution

give tabs a fixed height, so it would be 40px instead of 39.6px

📝 Changelog description

Describe changes from user side, and list all potential break changes or other risks.

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Mar 9, 2019

Deploy preview for ant-design ready!

Built with commit a0bfe4c

https://deploy-preview-15299--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #15299 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15299   +/-   ##
=======================================
  Coverage    94.1%    94.1%           
=======================================
  Files         250      250           
  Lines        6635     6635           
  Branches     1906     1938   +32     
=======================================
  Hits         6244     6244           
  Misses        390      390           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf138cb...a0bfe4c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #15299 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15299   +/-   ##
=======================================
  Coverage    94.1%    94.1%           
=======================================
  Files         250      250           
  Lines        6635     6635           
  Branches     1906     1938   +32     
=======================================
  Hits         6244     6244           
  Misses        390      390           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf138cb...a0bfe4c. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Mar 9, 2019

It will resolve #15234 too.

@afc163 afc163 merged commit 75a2038 into ant-design:master Mar 9, 2019
@zombieJ
Copy link
Member

zombieJ commented Mar 9, 2019

Seems this makes < 90% style not correct...
屏幕快照 2019-03-09 下午6 29 06

@rinick
Copy link
Contributor Author

rinick commented Mar 17, 2019

Seems this makes < 90% style not correct...
屏幕快照 2019-03-09 下午6 29 06

the second tab's height is 39px, and browser shows 38.99px when I scale it to 90%.
It's really annoying that it can still block a line at 40px.
But I have another idea, let me try fix it in a different PR

This was referenced Mar 17, 2019
afc163 pushed a commit that referenced this pull request Mar 18, 2019
* another try of fixing tab style

* fix card mode tab bottom line animation

#15299
#15297
#15234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants