Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another try of fixing tab style #15458

Merged
merged 2 commits into from
Mar 18, 2019
Merged

another try of fixing tab style #15458

merged 2 commits into from
Mar 18, 2019

Conversation

rinick
Copy link
Contributor

@rinick rinick commented Mar 17, 2019

🤔 This is a ...

  • Bug fix

👻 What's the background?

#15299
#15297
#15234

@zombieJ pointed out the previous PR doesn't fully fix the issue

💡 Solution

stop show hide the line based on if tab block the bottom border
new style would always block the border, and if a line is needed, show the line inside the tab

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Mar 17, 2019

Deploy preview for ant-design ready!

Built with commit 338b384

https://deploy-preview-15458--ant-design.netlify.com

@afc163
Copy link
Member

afc163 commented Mar 17, 2019

切换的时候,下边框会闪一下。

@codecov
Copy link

codecov bot commented Mar 17, 2019

Codecov Report

Merging #15458 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15458      +/-   ##
==========================================
- Coverage   94.33%    94.3%   -0.04%     
==========================================
  Files         250      250              
  Lines        6653     6653              
  Branches     1934     1948      +14     
==========================================
- Hits         6276     6274       -2     
- Misses        376      378       +2     
  Partials        1        1
Impacted Files Coverage Δ
components/upload/UploadList.tsx 94.49% <0%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d96ba6...338b384. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Mar 17, 2019

Codecov Report

Merging #15458 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15458      +/-   ##
==========================================
- Coverage   94.33%    94.3%   -0.04%     
==========================================
  Files         250      250              
  Lines        6653     6653              
  Branches     1934     1948      +14     
==========================================
- Hits         6276     6274       -2     
- Misses        376      378       +2     
  Partials        1        1
Impacted Files Coverage Δ
components/upload/UploadList.tsx 94.49% <0%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d96ba6...338b384. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 17, 2019

Codecov Report

Merging #15458 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15458      +/-   ##
==========================================
- Coverage   94.33%    94.3%   -0.04%     
==========================================
  Files         250      250              
  Lines        6653     6653              
  Branches     1934     1948      +14     
==========================================
- Hits         6276     6274       -2     
- Misses        376      378       +2     
  Partials        1        1
Impacted Files Coverage Δ
components/upload/UploadList.tsx 94.49% <0%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d96ba6...338b384. Read the comment docs.

@rinick
Copy link
Contributor Author

rinick commented Mar 17, 2019

切换的时候,下边框会闪一下。

@afc163 fixed

@afc163
Copy link
Member

afc163 commented Mar 18, 2019

@rinick Great job!

@afc163 afc163 merged commit b1ec61a into ant-design:master Mar 18, 2019
@zombieJ
Copy link
Member

zombieJ commented Mar 18, 2019

Safari 和 FF 下还是不太对,要不然只留 active 的 border-bottom?

Safari
屏幕快照 2019-03-18 下午12 08 17

Firefox
屏幕快照 2019-03-18 下午12 09 28

@afc163
Copy link
Member

afc163 commented Mar 18, 2019

image

@rinick
Copy link
Contributor Author

rinick commented Mar 18, 2019

Safari 和 FF 下还是不太对,要不然只留 active 的 border-bottom?

Safari
屏幕快照 2019-03-18 下午12 08 17

Firefox
屏幕快照 2019-03-18 下午12 09 28

额,大概可行。
不过这个应该算是浏览器bug了吧,firefox inspector显示内外两个element位置和height完全一样,为什么在缩放的时候bottom border的位置会不一样

@zombieJ
Copy link
Member

zombieJ commented Mar 18, 2019

不过这个应该算是浏览器bug了吧,firefox inspector显示内外两个element位置和height完全一样,为什么在缩放的时候bottom border的位置会不一样

缩放后如何展示不在 spec 里,浏览器的表现不同不能算是 bug。看着修修,实在不行,就到此为止了……

@afc163 afc163 mentioned this pull request Apr 16, 2019
1 task
@mankeheaven
Copy link

非100%缩放后,1px问题确实挺恼火的,浏览器对于这种亚像素演变,计算,总会感觉怪怪的。
我目前有用thin替换1px, 处理单个,或者采用margin-top,margin-bottom,和height搭配,处理列表,暂时看上去相安无事。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants