-
-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
another try of fixing tab style #15458
Conversation
Deploy preview for ant-design ready! Built with commit 338b384 |
切换的时候,下边框会闪一下。 |
Codecov Report
@@ Coverage Diff @@
## master #15458 +/- ##
==========================================
- Coverage 94.33% 94.3% -0.04%
==========================================
Files 250 250
Lines 6653 6653
Branches 1934 1948 +14
==========================================
- Hits 6276 6274 -2
- Misses 376 378 +2
Partials 1 1
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #15458 +/- ##
==========================================
- Coverage 94.33% 94.3% -0.04%
==========================================
Files 250 250
Lines 6653 6653
Branches 1934 1948 +14
==========================================
- Hits 6276 6274 -2
- Misses 376 378 +2
Partials 1 1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #15458 +/- ##
==========================================
- Coverage 94.33% 94.3% -0.04%
==========================================
Files 250 250
Lines 6653 6653
Branches 1934 1948 +14
==========================================
- Hits 6276 6274 -2
- Misses 376 378 +2
Partials 1 1
Continue to review full report at Codecov.
|
@afc163 fixed |
@rinick Great job! |
缩放后如何展示不在 spec 里,浏览器的表现不同不能算是 bug。看着修修,实在不行,就到此为止了…… |
非100%缩放后,1px问题确实挺恼火的,浏览器对于这种亚像素演变,计算,总会感觉怪怪的。 |
🤔 This is a ...
👻 What's the background?
#15299
#15297
#15234
@zombieJ pointed out the previous PR doesn't fully fix the issue
💡 Solution
stop show hide the line based on if tab block the bottom border
new style would always block the border, and if a line is needed, show the line inside the tab
☑️ Self Check before Merge