Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@ngtools/webpack): files are not being updated when using allowJs or resolveJsonModule #13089

Merged
merged 3 commits into from
Nov 30, 2018
Merged

fix(@ngtools/webpack): files are not being updated when using allowJs or resolveJsonModule #13089

merged 3 commits into from
Nov 30, 2018

Commits on Nov 29, 2018

  1. fix(@ngtools/webpack): files are not being updated when using `allowJ… 

    …s` or `resolveJsonModule`

Fixes #13076 and Fixes #12964
    @alan-agius4
    alan-agius4 committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    25303f2 View commit details
    Browse the repository at this point in the history

  2. test: add tests for allowJs and resolveJsonModule in watch mode

    @alan-agius4
    alan-agius4 committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    377cc90 View commit details
    Browse the repository at this point in the history

  3. test: improve tests for allowJs 

    When not using `allowJs` js files are not processed by the tsc compiler, but still processed by webpack.

So a correct test should be to check that the JS is transpiled down to ES5 syntax.
    @alan-agius4
    alan-agius4 committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    66a8171 View commit details
    Browse the repository at this point in the history