fix(@ngtools/webpack): files are not being updated when using allowJs or resolveJsonModule
#13089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
When not using `allowJs` js files are not processed by the tsc compiler, but still processed by webpack. So a correct test should be to check that the JS is transpiled down to ES5 syntax.
alan-agius4
added
target: patch
vikerman
pushed a commit
that referenced
this pull request
Nov 30, 2018
…s` or `resolveJsonModule` (#13089) * fix(@ngtools/webpack): files are not being updated when using `allowJs` or `resolveJsonModule` Fixes #13076 and Fixes #12964 * test: add tests for allowJs and resolveJsonModule in watch mode * test: improve tests for `allowJs` When not using `allowJs` js files are not processed by the tsc compiler, but still processed by webpack. So a correct test should be to check that the JS is transpiled down to ES5 syntax.
This was referenced Dec 3, 2018
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13076 and Fixes #12964