Clearer flow type tests with commonjs variant

zertosh · Sep 9, 2018 · bed21a1 · bed21a1
1 parent 0f54a01
commit bed21a1
Show file tree

Hide file tree

Showing 5 changed files with 53 additions and 22 deletions.
diff --git a/__tests__/__fixtures__/flow-package/.flowconfig b/__tests__/__fixtures__/flow-package/.flowconfig
@@ -1,5 +1,8 @@
 [include]
 ../../..
 
+[ignore]
+.*/node_modules/.*
+
 [version]
 0.80.0
diff --git a/__tests__/__fixtures__/flow-package/commonjs.js b/__tests__/__fixtures__/flow-package/commonjs.js
@@ -0,0 +1,11 @@
+/* @flow */
+
+var nullthrows = require('../../..').default;
+
+var obj = ({}: ?Object);
+
+var bad1: Object = obj;
+var ok1: Object = nullthrows(obj);
+
+nullthrows(null);
+nullthrows(null, 'my error message');
diff --git a/__tests__/__fixtures__/flow-package/esmodule.js b/__tests__/__fixtures__/flow-package/esmodule.js
@@ -0,0 +1,11 @@
+/* @flow */
+
+import nullthrows from '../../..';
+
+var obj = ({}: ?Object);
+
+var bad1: Object = obj;
+var ok1: Object = nullthrows(obj);
+
+nullthrows(null);
+nullthrows(null, 'my error message');
diff --git a/__tests__/__fixtures__/flow-package/index.js b/__tests__/__fixtures__/flow-package/index.js
diff --git a/__tests__/__snapshots__/typechecker-test.js.snap b/__tests__/__snapshots__/typechecker-test.js.snap
@@ -3,25 +3,42 @@
 exports[`nullthrows with flow 1`] = `""`;
 
 exports[`nullthrows with flow 2`] = `
-"Error --------------------------------------------------------------- __tests__/__fixtures__/flow-package/index.js:11:20
+"Error ------------------------------------------------------------- __tests__/__fixtures__/flow-package/commonjs.js:7:20
 
 Cannot assign \`obj\` to \`bad1\` because null or undefined [1] is incompatible with object type [2].
 
-   __tests__/__fixtures__/flow-package/index.js:11:20
-   11| var bad1: Object = obj;
-                          ^^^
+   __tests__/__fixtures__/flow-package/commonjs.js:7:20
+   7| var bad1: Object = obj;
+                         ^^^
 
 References:
-   __tests__/__fixtures__/flow-package/index.js:5:16
-    5| var obj = ({}: ?Object);
-                      ^^^^^^^ [1]
-   __tests__/__fixtures__/flow-package/index.js:11:11
-   11| var bad1: Object = obj;
-                 ^^^^^^ [2]
+   __tests__/__fixtures__/flow-package/commonjs.js:5:16
+   5| var obj = ({}: ?Object);
+                     ^^^^^^^ [1]
+   __tests__/__fixtures__/flow-package/commonjs.js:7:11
+   7| var bad1: Object = obj;
+                ^^^^^^ [2]
 
 
+Error ------------------------------------------------------------- __tests__/__fixtures__/flow-package/esmodule.js:7:20
 
-Found 1 error
+Cannot assign \`obj\` to \`bad1\` because null or undefined [1] is incompatible with object type [2].
+
+   __tests__/__fixtures__/flow-package/esmodule.js:7:20
+   7| var bad1: Object = obj;
+                         ^^^
+
+References:
+   __tests__/__fixtures__/flow-package/esmodule.js:5:16
+   5| var obj = ({}: ?Object);
+                     ^^^^^^^ [1]
+   __tests__/__fixtures__/flow-package/esmodule.js:7:11
+   7| var bad1: Object = obj;
+                ^^^^^^ [2]
+
+
+
+Found 2 errors
 "
 `;