Added disabled prop #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverted .babelrc changes Added disabled as false to test snapshots Added simple test for the new disabled prop - we could probably add more tests around it, such as confirming that it closes the popup when disabled is changed to true Added disabled to componentApi.md
|
Good job! Please merge this and upgrade. Thanks! |
|
Hey raRaRa, could we fix this and tell the maintainer to update the component? |
|
I've merged the changes. Can you look into this @yjose |
Merged
|
Thanks @yjose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new prop
disabledwhich disables the popup from showing up. It also closes the popup if it's open whendisabledis changed fromfalsetotrue.