Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency micromatch to ^3.0.0 #5187

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 8, 2018

This Pull Request updates dependency micromatch from ^2.3.11 to ^3.0.0

Commits

v3.0.0

v3.0.1

v3.0.2

v3.0.3

v3.0.4

  • b954ab5 3.0.3
  • 7c4657e add link to release notes
  • 0fd6207 fixes #​96
  • 719ce7f fixing typo in PR template
  • 5effb6c Merge pull request #​98 from micromatch/pr-template-typo
  • 6ca8ba6 Merge pull request #​97 from micromatch/unixify-not
  • e623c41 run verb to generate readme
  • 12e9d37 3.0.4

v3.0.5

  • ba5347b Adding additional tests
  • e184907 Add micromatch.capture to return captured matches
  • caa77dc Merge pull request #​104 from fidian/extglob-tests
  • 8843445 negation character class examples
  • 1d2d9a0 define path in helper
  • 3ed78e0 fix generated patterns
  • d4d41fd run update, lint, upgrade deps
  • 605d4cf format unit tests, add tests for https://github.com/micromatch/micromatch/issues/100
  • 626529a fix tests per bash spec
  • 352b789 fix lint-deps config
  • d0ae95b run verb to generate readme documentation
  • edbfb23 3.0.5

v3.1.0

  • 3c500b4 Merge pull request #​105 from devongovett/capture
  • b3516ed update benchmark code
  • 40c1cbe run verb to generate readme documentation
  • 896a310 3.1.0

v3.1.1

  • 3465906 lint, minor edits to private variable
  • b356fa1 force bump deps to get fixes in braces and nanomatch
  • 379db73 run verb to generate readme documentation

v3.1.2

v3.1.3

v3.1.4

v3.1.5

v3.1.6

  • 83f21ff 3.1.5
  • 032499a fix(compilers): Do not add a backward slash to the text node
  • 3620e87 Merge pull request #​117 from mrmlnc/ISSUE-116
  • cdff648 run update, lint tests, upgrade deps
  • 3460dfb update slash chars based on nanomatch, add tests
  • ee0bdc0 bump nanomatch

v3.1.7

v3.1.8

v3.1.9


This PR has been generated by Renovate Bot.

@rarkins
Copy link
Contributor

rarkins commented Jan 11, 2018

ci/circlei:build has this strange failure:

+ chmod +x artifacts/yarn-1.3.2.js artifacts/yarn-legacy-1.3.2.js
+ ((  node_version > 4  ))
++ node artifacts/yarn-1.3.2.js --version
Error: Cannot find module "."
    at webpackMissingModule (/root/project/yarn/artifacts/yarn-1.3.2.js:104850:82)
    at Object.module.exports.module.exports (/root/project/yarn/artifacts/yarn-1.3.2.js:104850:160)
    at __webpack_require__ (/root/project/yarn/artifacts/yarn-1.3.2.js:22:30)
    at Object.<anonymous> (/root/project/yarn/artifacts/yarn-1.3.2.js:104479:13)
    at __webpack_require__ (/root/project/yarn/artifacts/yarn-1.3.2.js:22:30)
    at Object.<anonymous> (/root/project/yarn/artifacts/yarn-1.3.2.js:100968:10)
    at __webpack_require__ (/root/project/yarn/artifacts/yarn-1.3.2.js:22:30)
    at Object.module.exports.exports.getArg (/root/project/yarn/artifacts/yarn-1.3.2.js:41198:12)
    at __webpack_require__ (/root/project/yarn/artifacts/yarn-1.3.2.js:22:30)
    at Object.<anonymous> (/root/project/yarn/artifacts/yarn-1.3.2.js:103345:18)
+ [[ 1.3.2 == '' ]]
+ exit 1
error Command failed with exit code 1.

Meanwhile the remaining failures are due to changes in the regex returned by thismicromatch line: const regex: ?RegExp = mm.makeRe(pattern.trim(), {dot: true, nocase: true});

Example change:

    -     "regex": /^(?:a)$/i,
    +     "regex": /^(?:(?:(?:\.(?:\/|\\))(?=.))?a)$/i,

The new regexes are very.. lengthened.

This project switched to micromatch soon before the 3.0 release, precisely for regex generation reasons: #3339

Cc @jrop

@renovate renovate bot force-pushed the renovate/micromatch-3.x branch 7 times, most recently from 6c96e76 to 32e1de3 Compare February 23, 2018 13:21
@arcanis
Copy link
Member

arcanis commented Feb 27, 2018

Closing - breaks the tests

@arcanis arcanis closed this Feb 27, 2018
@renovate
Copy link
Contributor Author

renovate bot commented Feb 27, 2018

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 3.x releases. However, if you upgrade to 3.x manually then Renovate will then reenable updates for minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/micromatch-3.x branch February 27, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants