Skip to content

Commit

Permalink
Don't report normal TODO comments as errors
Browse files Browse the repository at this point in the history
  • Loading branch information
sindresorhus committed Sep 26, 2019
1 parent 1c8e762 commit 4378e83
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
8 changes: 8 additions & 0 deletions config/plugins.js
Expand Up @@ -50,6 +50,14 @@ module.exports = {
// TODO: Remove this override when the rule is more stable.
'unicorn/consistent-function-scoping': 'off',

// TODO: Change the rule default for this.
'unicorn/expiring-todo-comments': [
'error',
{
allowWarningComments: true
}
],

// TODO: Temporarily disabled as the rule is buggy.
'function-call-argument-newline': 'off',

Expand Down
3 changes: 1 addition & 2 deletions test/open-report.js
Expand Up @@ -21,8 +21,7 @@ test('opens nothing when there are no errors nor warnings', async t => {
t.pass();
});

// TODO: Fix the logic causing this to fail.
test.failing('only opens errors if there are errors and warnings', async t => {
test('only opens errors if there are errors and warnings', async t => {
const glob = path.join(__dirname, 'fixtures/open-report/**');
const results = await fn.lintFiles(glob);

Expand Down

0 comments on commit 4378e83

Please sign in to comment.