deprecate children prop #3069
Closed
deprecate children prop #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adids1221 What about all of our inner usages of Picker.Item and the PickerItem API? |
|
@Inbal-Tish I'll do it in another PR before moving to the error phase. |
Why? If you're deprecating something we should stop using it internally. This will also provide an example for the migration, and make sure there are not issues with this deprecations (at least on our side) |
|
Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Picker children prop deprecation.
As part of the Picker refactor we are deprecating the children prop and moving to use the items prop.
Children cleanup from Picker internal code will be done after merging this PR.
Changelog
Picker children prop deprecation.
Additional info
MADS-4180