TextField - new outline preset #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
changed the base branch from
master
to
feat/TextField_underline_preset
…nto feat/TextField_outline_preset # Conflicts: # demo/src/screens/componentScreens/TextFieldScreen.tsx # src/components/textField/types.ts # src/components/textField/usePreset.ts
Inbal-Tish
added
Important for Next Release
ethanshar
approved these changes
May 19, 2024
| @@ -74,6 +80,7 @@ export default class TextFieldScreen extends Component { | |||
| /> | |||
| <TextField | |||
| placeholder="Placeholder" | |||
| placeholderTextColor={Colors.$textNeutralLight} | |||
There was a problem hiding this comment.
Why are you setting a different placeholderColor here?
There was a problem hiding this comment.
I was just testing new token. Removed
| this.setState({preset: index === 0 ? 'underline' : 'outline'}); | ||
| }; | ||
|
|
||
| getDynamicFieldStyle = (context, props) => { |
There was a problem hiding this comment.
This behavior can be achieved by passing a color object with all states, any reason you are doing it like this?
There was a problem hiding this comment.
We don't have a prop to control the underline color with the ColorType... What are you referring to?
|
@ethanshar I added another change to the demo's configuration file to allow overriding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TextField - new outline preset
based on: #3065
Changelog
TextField - new outline preset
Additional info
ticket 4172