Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/segemented control new UI preset #3061

Merged
merged 23 commits into from May 23, 2024
Merged

Feat/segemented control new UI preset #3061

merged 23 commits into from May 23, 2024
+202 −66

Conversation

nitzanyiz
Copy link
Contributor

Description

Segmented Control Form preset added. I created a "hook" that returns new props according to the preset.

Changelog

SegmentedControl - New form preset added.

Additional info

MADS-4065

@nitzanyiz nitzanyiz requested a review from Inbal-Tish May 9, 2024 10:09
@nitzanyiz nitzanyiz added this to the Form milestone May 9, 2024
@nitzanyiz nitzanyiz marked this pull request as ready for review May 9, 2024 10:54
@Inbal-Tish
Copy link
Collaborator

@nitzanyiz Where is the example?

@Inbal-Tish
Copy link
Collaborator

Inbal-Tish commented May 12, 2024 •
edited

@nitzanyiz Looks great. Left small comments. Also, I have a warning poping-up "Each child in a list should have a unique "key" prop. Check the render method of 'SegmentedControl'". Please take a look

@Inbal-Tish
Copy link
Collaborator

Inbal-Tish commented May 12, 2024 •
edited

Oh sorry. Figma link:

Please don't add private links to the public repo.
I meant the example in the demo screen...

@nitzanyiz nitzanyiz requested a review from Inbal-Tish May 12, 2024 10:30
@nitzanyiz
Copy link
Contributor Author

  • change to enum and set it on the component
  • added the preset change to the screen
  • removed the extra reanimated view if there is no divider.

@nitzanyiz nitzanyiz requested a review from Inbal-Tish May 13, 2024 08:35
@Inbal-Tish Inbal-Tish assigned nitzanyiz and unassigned Inbal-Tish May 20, 2024
@nitzanyiz nitzanyiz assigned Inbal-Tish and unassigned nitzanyiz May 20, 2024
@nitzanyiz nitzanyiz requested a review from Inbal-Tish May 20, 2024 09:42
@Inbal-Tish Inbal-Tish assigned nitzanyiz and unassigned Inbal-Tish May 20, 2024
@nitzanyiz nitzanyiz assigned Inbal-Tish and unassigned nitzanyiz May 22, 2024
@Inbal-Tish Inbal-Tish merged commit c7b54a0 into master May 23, 2024
1 check passed
@Inbal-Tish Inbal-Tish deleted the feat/SegementedControlNewUIPreset branch May 23, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar left review comments

@Inbal-Tish Inbal-Tish Inbal-Tish approved these changes

Assignees

@Inbal-Tish Inbal-Tish

Labels
None yet
Projects
None yet
Milestone
Form
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nitzanyiz @Inbal-Tish @ethanshar