Fix/carousel initial page on android #3047
Conversation
| @@ -520,7 +520,7 @@ class Carousel extends Component<CarouselProps, CarouselState> { | |||
| pagingEnabled={this.shouldEnablePagination()} | |||
| snapToOffsets={snapToOffsets} | |||
| contentOffset={contentOffset} | |||
| // onContentSizeChange={this.onContentSizeChange} | |||
| onContentSizeChange={this.onContentSizeChange} | |||
There was a problem hiding this comment.
Did you checked it's not messing up something related to this PR ?
There was a problem hiding this comment.
I saw that they commented that this might not be needed in their pr. It seems to fix the starting page problem now.
Regarding the ticket the the PR you mentioned fixed. Its not reproduced after this change.
There was a problem hiding this comment.
I used this fix and tested in on our demo app, in Android phone in Hebrew.
The index does fixed in RTL, but the initial index passed is 0 and on RTL it's starting on 6, does this PR should solve this also ?
There was a problem hiding this comment.
How did you reproduce this? What code did you use?
There was a problem hiding this comment.
Run the app on Android emulator, make sure to force RTL.
In the carousel screen (in the private repo) check the INITIAL_PAGE value, the currentPage in the state is the reversed value of the INITIAL_PAGE.
Description
Fix for the carousel initial page rendering. Android had a bug where on RTL with initialPage 0 it would start with a different initial page.
Changelog
Carousel - Fix initial page on android rtl.
Additional info
MADS-3895