ExpandableSection - add minHeight #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Apr 30, 2024
| /** | ||
| * Set a minimum height for the expandableSection | ||
| * If the children height is less than the minHeight, the expandableSection will collapse to that height | ||
| * If the children height is greater than the minHeight, the expandableSection will result with only the children rendered |
There was a problem hiding this comment.
Not clear "will result with only the children rendered". Do you mean "no height limit will apply"?
There was a problem hiding this comment.
Added (sectionHeader will not be rendered)
Inbal-Tish
reviewed
Apr 30, 2024
| return ( | ||
| <ScrollView> | ||
| <View row center margin-20> |
There was a problem hiding this comment.
Missing our usual title "ExpandableSection"
There was a problem hiding this comment.
Some screens do not have that and we have it in the RNN title
There was a problem hiding this comment.
I know, but it's strange the the title is "Minimum Height"...
Inbal-Tish
reviewed
Apr 30, 2024
| const toValue = expanded ? height : collapsedHeight; | ||
| animatedHeight.value = shouldAnimate ? withTiming(toValue) : toValue; | ||
| }, | ||
| [animatedHeight, expanded, height, minHeight]); |
There was a problem hiding this comment.
no need to break the line here
There was a problem hiding this comment.
This is how prettify is indenting for me
Inbal-Tish
approved these changes
May 1, 2024
M-i-k-e-l
added a commit
that referenced
this pull request
May 1, 2024
* ExpandableSection - add minHeight * Polish screen * Fix docs * Whatever
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ExpandableSection - add minHeight
Changelog
ExpandableSection - add minHeight
Additional info
Ticket 4116