Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/hint message location #2967

Closed
wants to merge 9 commits into from
Closed

Fix/hint message location #2967

wants to merge 9 commits into from

Conversation

nitzanyiz
Copy link
Contributor

Description

Fix for Hint tip and message not in same location bug. When the hint is pointing to component that is large the hint and tip are placed at different location (will probably happen when width of component is larger than 1/3 of the screen). Tip location is correct, message is not.
Snippets for reproducing:
Tablet:

<View flex paddingT-100>
  <Hint message={'This is a hint'} visible>
    <View width={800}>
      <Button label="Hint me"/>
    </View>
  </Hint>
</View>

Phone:

<View flex paddingT-100>
  <Hint message={'This is a hint'} visible>
    <View width={300}>
      <Button label="Hint me"/>
    </View>
  </Hint>
</View>

Changelog

Hint - Big fix where tip and message are not at same location.

Additional info

MADS-3858

@nitzanyiz nitzanyiz requested a review from M-i-k-e-l March 5, 2024 10:46
@nitzanyiz nitzanyiz marked this pull request as ready for review March 5, 2024 10:46
@nitzanyiz nitzanyiz marked this pull request as draft March 11, 2024 13:59
@nitzanyiz nitzanyiz added this to the Quality milestone Mar 11, 2024
@nitzanyiz nitzanyiz removed the request for review from M-i-k-e-l March 12, 2024 13:07
@nitzanyiz nitzanyiz closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants