ExpandableOverlay testkit driver #2917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
Feb 7, 2024
M-i-k-e-l
reviewed
Feb 18, 2024
M-i-k-e-l
reviewed
Feb 18, 2024
M-i-k-e-l
reviewed
Feb 18, 2024
M-i-k-e-l
reviewed
Apr 7, 2024
| import {type ComponentProps, useComponentDriver} from '../../testkit/new/Component.driver'; | ||
| import {usePressableDriver} from '../../testkit/new/usePressable.driver'; | ||
|
|
||
| type OverlayDriverType<Props extends ExpandableOverlayProps> = Props extends {useDialog: true} |
There was a problem hiding this comment.
We need to remove the types
M-i-k-e-l
reviewed
Apr 7, 2024
| testID: `${testID}.overlay` | ||
| }) as OverlayDriverType<Props>; | ||
|
|
||
| const getOverlay = () => { |
There was a problem hiding this comment.
This should probably return isVisible and not the implementation detials
M-i-k-e-l
reviewed
Apr 7, 2024
| driver.press(); | ||
| expect(driver.getOverlay().getModal().isVisible()).toBeTruthy(); | ||
| }); | ||
| const universe = 'Hello Universe'; |
There was a problem hiding this comment.
Why not put this at the top of the file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testkit driver for the ExpandableOverlay.
Changelog
None
Additional info
None