Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dialog test to actually test for existence #2909

Merged
merged 1 commit into from May 5, 2024
Merged

Fixed dialog test to actually test for existence #2909

merged 1 commit into from May 5, 2024

Conversation

nitzanyiz
Copy link
Contributor

@nitzanyiz nitzanyiz commented Jan 23, 2024 •
edited

Description

I changed the test so it would test for existence of the dialog instead of testing for the visibility of the modal. I thought they're the same thing.

Changelog

None

Additional info

None

@nitzanyiz nitzanyiz marked this pull request as ready for review January 23, 2024 13:47
@nitzanyiz nitzanyiz changed the title Fixed dialog test to actually test for existent Fixed dialog test to actually test for existence Jan 25, 2024
M-i-k-e-l
M-i-k-e-l reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically exists and visible are not the same.
What triggered you to make this change?
In any case, I'd consider testing for both things

@stale Stale
Copy link

stale bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 22, 2024
@M-i-k-e-l M-i-k-e-l merged commit 63bf9e4 into master May 5, 2024
1 check passed
@M-i-k-e-l M-i-k-e-l deleted the infra/DialogTestFix branch May 5, 2024 09:47
@stale stale bot removed the wontfix label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nitzanyiz @M-i-k-e-l