Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simctrl terminate message change on v19 #4461

Closed

Conversation

jasminmif
Copy link

The simtrl terminate error has changed again which is causing the Detox tests to fail for people still using the v19.

Can we have a new release of 19.13.1 including this fix pls. Ty

This was already fixed for v20 #4171

@jasminmif jasminmif changed the title Fix simctrl terminate message change Fix simctrl terminate message change on v19 Apr 24, 2024
@noomorph
Copy link
Collaborator

@jasminmif is there an objective reason why migrating to 19.x is impossible for you?

@jasminmif
Copy link
Author

@jasminmif is there an objective reason why migrating to 19.x is impossible for you?

V20 does not support Mocha so it's going to be a bug lift doing the migration.

@noomorph
Copy link
Collaborator

Uh-oh, I see.

Well, our build pipeline is not well optimized for backport releases, unfortunately, so it's going to be quicker for you to download detox 19.x tgz from npm. Patch it, and republish it as a scoped package, e.g. @jasminmif/detox .

I can't promise to return to build workflow tweaks/customizations/improvements earlier than mid-summer, so the previous advise may be more feasible for you.

@jasminmif
Copy link
Author

Uh-oh, I see.

Well, our build pipeline is not well optimized for backport releases, unfortunately, so it's going to be quicker for you to download detox 19.x tgz from npm. Patch it, and republish it as a scoped package, e.g. @jasminmif/detox .

I can't promise to return to build workflow tweaks/customizations/improvements earlier than mid-summer, so the previous advise may be more feasible for you.

Yeah, thats what I ended up doing. Thanks, will close this one.

@jasminmif jasminmif closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants