[fix] Use crypto.randomBytes() to generate the masking key

websockets · Nov 25, 2016 · 7253f06 · 7253f06
1 parent 269dff8
commit 7253f06
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/lib/Sender.js b/lib/Sender.js
@@ -6,6 +6,8 @@
 
 'use strict';
 
+const crypto = require('crypto');
+
 const PerMessageDeflate = require('./PerMessageDeflate');
 const bufferUtil = require('./BufferUtil').BufferUtil;
 const ErrorCodes = require('./ErrorCodes');
@@ -364,12 +366,7 @@ function toBuffer (data) {
  * @private
  */
 function getRandomMask () {
-  return new Buffer([
-    ~~(Math.random() * 255),
-    ~~(Math.random() * 255),
-    ~~(Math.random() * 255),
-    ~~(Math.random() * 255)
-  ]);
+  return crypto.randomBytes(4);
 }
 
 /**