[minor] Use Infinity if concurrency value is falsy

Refs: 950e41a8#r36203961
websockets · Nov 30, 2019 · 6df06d9 · 6df06d9
1 parent 950e41a
commit 6df06d9
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 16 deletions.
diff --git a/lib/limiter.js b/lib/limiter.js
@@ -19,7 +19,7 @@ class Limiter {
       this.pending--;
       this[kRun]();
     };
-    this.concurrency = concurrency;
+    this.concurrency = concurrency || Infinity;
     this.jobs = [];
     this.pending = 0;
   }

diff --git a/test/limiter.test.js b/test/limiter.test.js
@@ -5,27 +5,37 @@ const assert = require('assert');
 const Limiter = require('../lib/limiter');
 
 describe('Limiter', () => {
-  it('limits the number of jobs allowed to run concurrently', (done) => {
-    const limiter = new Limiter(1);
+  describe('#ctor', () => {
+    it('takes a `concurrency` argument', () => {
+      const limiter = new Limiter(0);
 
-    limiter.add((callback) => {
-      setImmediate(() => {
-        callback();
+      assert.strictEqual(limiter.concurrency, Infinity);
+    });
+  });
+
+  describe('#kRun', () => {
+    it('limits the number of jobs allowed to run concurrently', (done) => {
+      const limiter = new Limiter(1);
+
+      limiter.add((callback) => {
+        setImmediate(() => {
+          callback();
 
-        assert.strictEqual(limiter.jobs.length, 0);
-        assert.strictEqual(limiter.pending, 1);
+          assert.strictEqual(limiter.jobs.length, 0);
+          assert.strictEqual(limiter.pending, 1);
+        });
       });
-    });
 
-    limiter.add((callback) => {
-      setImmediate(() => {
-        callback();
+      limiter.add((callback) => {
+        setImmediate(() => {
+          callback();
 
-        assert.strictEqual(limiter.pending, 0);
-        done();
+          assert.strictEqual(limiter.pending, 0);
+          done();
+        });
       });
-    });
 
-    assert.strictEqual(limiter.jobs.length, 1);
+      assert.strictEqual(limiter.jobs.length, 1);
+    });
   });
 });