Merge pull request #6844 from swederik/issue-6843

Add handling for devtool source-map with library specified as Object
webpack · Mar 26, 2018 · fc2feaf · fc2feaf
2 parents eba38f1 + 7fcd281
commit fc2feaf
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/lib/WebpackOptionsDefaulter.js b/lib/WebpackOptionsDefaulter.js
@@ -136,6 +136,8 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
 		this.set("output.devtoolNamespace", "make", options => {
 			if (Array.isArray(options.output.library))
 				return options.output.library.join(".");
+			else if (typeof options.output.library === "object")
+				return options.output.library.root || "";
 			return options.output.library || "";
 		});
 		this.set("output.libraryTarget", "var");

diff --git a/test/configCases/source-map/object-as-output-library/index.js b/test/configCases/source-map/object-as-output-library/index.js
@@ -0,0 +1 @@
+it("should compile successfully when output.library is an object of type:name", function() {});
diff --git a/test/configCases/source-map/object-as-output-library/webpack.config.js b/test/configCases/source-map/object-as-output-library/webpack.config.js
@@ -0,0 +1,11 @@
+module.exports = {
+	devtool: "source-map",
+	output: {
+		library: {
+			root: "[name]",
+			amd: "[name]",
+			commonjs: "[name]"
+		},
+		libraryTarget: "umd"
+	}
+};