Merge pull request #8405 from xiaoxiaojx/fix-function-plugin-apply

fix parameter missing when plugin type is a funtion
webpack · Nov 29, 2018 · e3e8a68 · e3e8a68
2 parents 8e841fe + 70b9a1b
commit e3e8a68
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/declarations/WebpackOptions.d.ts b/declarations/WebpackOptions.d.ts
@@ -225,6 +225,7 @@ export type ArrayOfStringOrStringArrayValues = (string | string[])[];
  * via the `definition` "WebpackPluginFunction".
  */
 export type WebpackPluginFunction = (
+	this: import("../lib/Compiler"),
 	compiler: import("../lib/Compiler")
 ) => void;
 /**

diff --git a/lib/webpack.js b/lib/webpack.js
@@ -42,7 +42,7 @@ const webpack = (options, callback) => {
 		if (options.plugins && Array.isArray(options.plugins)) {
 			for (const plugin of options.plugins) {
 				if (typeof plugin === "function") {
-					plugin.apply(compiler);
+					plugin.call(compiler, compiler);
 				} else {
 					plugin.apply(compiler);
 				}

diff --git a/schemas/WebpackOptions.json b/schemas/WebpackOptions.json
@@ -1879,7 +1879,7 @@
     "WebpackPluginFunction": {
       "description": "Function acting as plugin",
       "instanceof": "Function",
-      "tsType": "(compiler: import('../lib/Compiler')) => void"
+      "tsType": "(this: import('../lib/Compiler'), compiler: import('../lib/Compiler')) => void"
     },
     "WebpackPluginInstance": {
       "description": "Plugin instance",